dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Published 20 hours ago • verified publisher icon dapr

Support custom subscriptions response.

Open maliming opened this issue 3 years ago • 6 comments

Description

This PR supports custom subscriptions response. Mainly to integrate Event-Bus in the ABP framework.

Issue reference

No

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [ ] Extended the documentation

maliming avatar Sep 29 '22 09:09 maliming

hi @halspang

Do you have time to review this PR?

maliming avatar Oct 24 '22 12:10 maliming

Thanks for opening this PR, but I'm not really sure what the point of this change is. Can you provide some more background on it?

halspang avatar Oct 24 '22 20:10 halspang

Thanks @halspang

The dapr/subscribe endpoint gets all endpoints that use TopicAttribute and returns JSON data.

This PR allows developers to change the subscription response, Such as hiding or dynamically adding some subscriptions.

This may not be commonly used, but it is convenient for some frameworks to integrate Dapr.

maliming avatar Oct 25 '22 01:10 maliming

@maliming - Thanks. However, it seems like WithTopic would do this, right? And any additional integrations would need to come from the runtime since this is a json that we return to the runtime, we need to adhere to its contract. Or am I missing something here?

halspang avatar Oct 27 '22 20:10 halspang

Yes, You're right.

We also have some concepts similar to publish/subscribe in our class library, and with the current design, we need to create a lot of controllers and methods for them and use TopicAttribute.

We want to create a controller and dynamically specify multiple topic/route.

maliming avatar Oct 28 '22 06:10 maliming

Hey guys, any update? 🌹

gdlcf88 avatar Apr 21 '23 07:04 gdlcf88