dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Migrate actors to use grpc

Open addjuarez opened this issue 3 years ago • 1 comments

Signed-off-by: addjuarez [email protected]

Description

Migrate .net actor implementation to use grpc by default.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #486

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

addjuarez avatar Sep 21 '22 21:09 addjuarez

Codecov Report

Merging #954 (4cae4c2) into master (1605ecd) will decrease coverage by 3.06%. The diff coverage is 1.44%.

@@            Coverage Diff             @@
##           master     #954      +/-   ##
==========================================
- Coverage   70.17%   67.11%   -3.06%     
==========================================
  Files         160      161       +1     
  Lines        5284     5526     +242     
  Branches      567      592      +25     
==========================================
+ Hits         3708     3709       +1     
- Misses       1442     1679     +237     
- Partials      134      138       +4     
Flag Coverage Δ
net6 67.02% <1.44%> (-3.06%) :arrow_down:
net7 67.02% <1.44%> (-3.06%) :arrow_down:
netcoreapp3.1 67.08% <1.44%> (-3.06%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Dapr.Actors/DaprGrpcInteractor.cs 0.00% <0.00%> (ø)
src/Dapr.Actors/DaprHttpInteractor.cs 44.79% <0.00%> (-7.04%) :arrow_down:
src/Dapr.Actors/Runtime/ActorRuntimeOptions.cs 72.34% <0.00%> (-4.94%) :arrow_down:
src/Dapr.Actors/Runtime/DaprStateProvider.cs 17.39% <0.00%> (+9.84%) :arrow_up:
src/Dapr.Actors/Client/ActorProxyFactory.cs 47.61% <10.00%> (-35.72%) :arrow_down:
src/Dapr.Actors/Runtime/ActorRuntime.cs 75.00% <10.00%> (-9.00%) :arrow_down:
src/Dapr.Actors/Client/ActorProxyOptions.cs 66.66% <33.33%> (-11.12%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 22 '22 00:09 codecov[bot]

How hard would it be to replicate any tests that the DaprHttpInteractor has for the DaprGrpcInteractor? It would also be good to make a base e2e test for the actors to ensure this works correctly.

I can make e2e tests for the grpcInteractor but the unit tests for grpc are a bit more complex.

addjuarez avatar Dec 16 '22 21:12 addjuarez