dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Published 20 hours ago • verified publisher icon dapr

preserve comparer of the original dictionary

Open tomhreb opened this issue 2 years ago • 3 comments

Signed-off-by: Tomas Hrebicek [email protected]

Description

Fixes issue #934

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

tomhreb avatar Aug 23 '22 11:08 tomhreb

@tomhreb - Thanks for opening this! I'm a little bit worried about removing case sensitivity though. What if people are depending on that?

I think this may be more what you're looking for #887?

halspang avatar Aug 29 '22 18:08 halspang

@halspang No, I don't think #887 is related.

Without the case sensitivity, this functionality does not work. The original dictionary in the .net core library has this case sensitivity. I still regard this as a bugfix.

tomhreb avatar Sep 19 '22 08:09 tomhreb

Hi @halspang, any idea if this will be approved?

Check that the base class in .net SDK really has StringComparer.OrdinalIgnoreCase.

https://github.com/dotnet/dotnet/blob/b8bc661a7429baa89070f3bee636b7fbc1309489/src/runtime/src/libraries/Microsoft.Extensions.Configuration/src/ConfigurationProvider.cs

tomhreb avatar Dec 08 '22 13:12 tomhreb