dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

actor ids and timer names

Open aktxyz opened this issue 4 years ago • 2 comments

encoding of actor ids and timer names?

I have noticed if I use some characters (like ?) in an actor id or timer name, things silently fail.

This kind of makes sense since these values eventually make their way into URL paths header to dapr sidecars.

But it seems like these values should either be encoded, or an exception should be thrown for invalid values.

aktxyz avatar Aug 26 '21 19:08 aktxyz

maybe beef up the ArgumentVerifier with some more scenarios?

ArgumentVerifier.ThrowIfNullOrEmpty(pubsubName, nameof(pubsubName));

aktxyz avatar Aug 29 '21 17:08 aktxyz

This makes sense - we should be url-encoding Actor Ids and probably names as well so this works end to end. As long as the Dapr sidecar will accept a %-encoded actor name or Id then we should tolerate it as well. We don't want the SDK to be stricter than the runtime itself is.

We'd happily accept a PR for this.

rynowak avatar Aug 31 '21 20:08 rynowak