dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Add support for ISO 8601 intervals

Open jigargandhi opened this issue 3 years ago • 4 comments

Describe the proposal

Runtime has added support for ISO 8601 intervals for reminders as per https://github.com/dapr/dapr/issues/2513. Make changes to SDK to support accordingly

jigargandhi avatar Jun 29 '21 12:06 jigargandhi

/assign

jigargandhi avatar Jun 29 '21 12:06 jigargandhi

@jigargandhi - what's the user-visible impact of this? The format that we use to register reminders is an implementation detail. users work with .NET types like TimeSpan.

rynowak avatar Jul 13 '21 18:07 rynowak

Apologies if the title/description is misleading

The goal here is to provide reminders with repetitions.

The current api for an Actor to register a reminder is protected async Task<IActorReminder> RegisterReminderAsync(string reminderName, byte[] state, TimeSpan dueTime, TimeSpan period)

To support reminders with repetitions, we can add an overload protected async Task<IActorReminder> RegisterReminderAsync(string reminderName, byte[] state, TimeSpan dueTime, TimeSpan period, uint repetitions)

The reminders api do provide ability to create reminders using ISO 8601 intervals, but I think we can add that later if users want to create intervals with that format. This may be because they might get that interval from an external systems.

jigargandhi avatar Jul 14 '21 04:07 jigargandhi

/assign

yash-nisar avatar Sep 08 '22 22:09 yash-nisar

@halspang Do you want to add this to 1.10 ?

yash-nisar avatar Oct 25 '22 05:10 yash-nisar