dotnet-sdk icon indicating copy to clipboard operation
dotnet-sdk copied to clipboard

Added option to override GrpcChannelOptions when adding DaprWorkflow (#7218)

Open humandigital-ruud opened this issue 1 year ago • 5 comments

Description

You can now use custom GrpcChannelOptions when using DaprWorkflow, in the same manner as was already the case when creating the DaprClient:

builder.Services.AddDaprWorkflow(options =>
{
    options.UseGrpcChannelOptions(new GrpcChannelOptions
    {
        MaxReceiveMessageSize = 32 * 1024 * 1024,
        MaxSendMessageSize = 32 * 1024 * 1024
    });
});

Issue reference

See issue: GRPC data receive limits (#7218)

humandigital-ruud avatar Feb 23 '24 10:02 humandigital-ruud

@humandigital-ruud Are you still interested in pursuing this PR?

philliphoff avatar Jun 25 '24 18:06 philliphoff

@humandigital-ruud Are you still interested in pursuing this PR?

I will discuss this with my co-worker to see if he can take this over from me and spend some more time on it to get it right

humandigital-ruud avatar Jun 27 '24 10:06 humandigital-ruud

@humandigital-ruud Are you still interested in pursuing this PR?

I will discuss this with my co-worker to see if he can take this over from me and spend some more time on it to get it right

Hi!

humandigital-michiel avatar Jun 27 '24 11:06 humandigital-michiel

hi @philliphoff i made some adjustments based on your feedback. One of my first contributions to dapr.

@philliphoff gentle reminder for this one.

humandigital-michiel avatar Jul 18 '24 13:07 humandigital-michiel

Refactored the changes. We need to do some internal review, because fundamentals changed. There is no unit test anymore on Workflow, because these we're removed some time ago, do you want these back?

humandigital-michiel avatar Oct 23 '24 08:10 humandigital-michiel

@humandigital-michiel This looks good on my end, but I'm showing the branch is out of date. Could you please merge the latest from master so I can complete this PR?

Thanks for putting this together!

WhitWaldo avatar Oct 30 '24 03:10 WhitWaldo

Thank you for your contribution @humandigital-michiel and @humandigital-ruud !

WhitWaldo avatar Nov 04 '24 20:11 WhitWaldo

@holopin-bot @humandigital-ruud Thanks Ruud! 👋

marcduiker avatar Dec 03 '24 09:12 marcduiker

Congratulations @humandigital-ruud, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4893y0739270cl7770ymniq

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

holopin-bot[bot] avatar Dec 03 '24 09:12 holopin-bot[bot]

@holopin-bot @humandigital-michiel Thanks Michiel! 💪

marcduiker avatar Dec 03 '24 09:12 marcduiker

Congratulations @humandigital-michiel, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4894fpi47810cl75e9ntzji

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

holopin-bot[bot] avatar Dec 03 '24 09:12 holopin-bot[bot]