Added option to override GrpcChannelOptions when adding DaprWorkflow (#7218)
Description
You can now use custom GrpcChannelOptions when using DaprWorkflow, in the same manner as was already the case when creating the DaprClient:
builder.Services.AddDaprWorkflow(options =>
{
options.UseGrpcChannelOptions(new GrpcChannelOptions
{
MaxReceiveMessageSize = 32 * 1024 * 1024,
MaxSendMessageSize = 32 * 1024 * 1024
});
});
Issue reference
See issue: GRPC data receive limits (#7218)
@humandigital-ruud Are you still interested in pursuing this PR?
@humandigital-ruud Are you still interested in pursuing this PR?
I will discuss this with my co-worker to see if he can take this over from me and spend some more time on it to get it right
@humandigital-ruud Are you still interested in pursuing this PR?
I will discuss this with my co-worker to see if he can take this over from me and spend some more time on it to get it right
Hi!
hi @philliphoff i made some adjustments based on your feedback. One of my first contributions to dapr.
@philliphoff gentle reminder for this one.
Refactored the changes. We need to do some internal review, because fundamentals changed. There is no unit test anymore on Workflow, because these we're removed some time ago, do you want these back?
@humandigital-michiel This looks good on my end, but I'm showing the branch is out of date. Could you please merge the latest from master so I can complete this PR?
Thanks for putting this together!
Thank you for your contribution @humandigital-michiel and @humandigital-ruud !
@holopin-bot @humandigital-ruud Thanks Ruud! 👋
Congratulations @humandigital-ruud, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4893y0739270cl7770ymniq
This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!
@holopin-bot @humandigital-michiel Thanks Michiel! 💪
Congratulations @humandigital-michiel, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm4894fpi47810cl75e9ntzji
This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!