#906 -Added methods in status API supports for saving and reading binary data
Description
#906 -Added methods in status API supports for saving and reading binary data.
Added methods to directly save and read Byte arrays. New methods defined in DaprClient.cs New methods implemented in DaprClientGrpc.cs Unit tests written in StateApITest.cs
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[906]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [x] Extended the documentation
Codecov Report
Attention: Patch coverage is 90.12346% with 8 lines in your changes are missing coverage. Please review.
Project coverage is 66.78%. Comparing base (
fd7168f) to head (4916d1a). Report is 34 commits behind head on master.
:exclamation: Current head 4916d1a differs from pull request most recent head ba6855c. Consider uploading reports for the commit ba6855c to get more accurate results
| Files | Patch % | Lines |
|---|---|---|
| src/Dapr.Client/DaprClientGrpc.cs | 90.12% | 6 Missing and 2 partials :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1116 +/- ##
==========================================
+ Coverage 66.45% 66.78% +0.32%
==========================================
Files 171 171
Lines 5750 5831 +81
Branches 624 635 +11
==========================================
+ Hits 3821 3894 +73
- Misses 1782 1788 +6
- Partials 147 149 +2
| Flag | Coverage Δ | |
|---|---|---|
| net6 | 66.78% <90.12%> (+0.32%) |
:arrow_up: |
| net7 | 66.78% <90.12%> (+0.32%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@halspang, @philliphoff - Thanks for your comments and sorry for the delay. Please review.
@divzi-p is this PR abandoned? I would be happy to pick this back up, if the original proposal was still wanted. Was there something blocking this?
@divzi-p If this is still something you're interested in contributing, please correct the last commit and sign off on it as we cannot accept code with an invalid DCO. If you can sign off on that and fix the build error, I'd be happy to give this a final review and see about merging it promptly.
@jev-e Absent anything else that comes up in review, I'm not sure that there's any other lingering work necessary on this issue. I haven't really flagged anything for good first issues in the repo, but if you're looking for ways to contribute, please ping me on Discord and I'd be happy to share some ideas with you.
@divzi-p If this is still something you're interested in contributing, please correct the last commit and sign off on it as we cannot accept code with an invalid DCO. If you can sign off on that and fix the build error, I'd be happy to give this a final review and see about merging it promptly.
@jev-e Absent anything else that comes up in review, I'm not sure that there's any other lingering work necessary on this issue. I haven't really flagged anything for good first issues in the repo, but if you're looking for ways to contribute, please ping me on Discord and I'd be happy to share some ideas with you.
@WhitWaldo - I have signedoff and fixed the build. Please check. Thank you.
@holopin-bot @divzi-p Thank you for contributing!
Congratulations @divzi-p, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/cm5qyavya32720clb67bkrxcy
This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!