docs icon indicating copy to clipboard operation
docs copied to clipboard
verified publisher icon dapr

Add Clickhouse state store docs v1.16

Open middt opened this issue 6 months ago • 7 comments

Thank you for helping make the Dapr documentation better!

Please follow this checklist before submitting:

  • [ ] Commits are signed with Developer Certificate of Origin (DCO - learn more)
  • [ ] Read the contribution guide
  • [ ] Commands include options for Linux, MacOS, and Windows within codetabs
  • [ ] New file and folder names are globally unique
  • [ ] Page references use shortcodes instead of markdown or URL links
  • [ ] Images use HTML style and have alternative text
  • [ ] Places where multiple code/command options are given have codetabs

In addition, please fill out the following to help reviewers understand this pull request:

Description

Issue reference

https://github.com/dapr/components-contrib/pull/3675

middt avatar Jun 27 '25 11:06 middt

@msfussell I've removed the unnecessary files—only the required ones remain. Thanks again for the feedback!

middt avatar Jul 01 '25 06:07 middt

@msfussell Thank you for the great feedback! 🙏 I've addressed all your suggestions: ✅ Fixed version: Changed since: "1.15" to since: "1.16" in generic.yaml ✅ Removed actor references: Removed all actor-related comments and sections since ClickHouse is not a transactional state store

Thanks for the thorough review and for helping make this contribution better!

middt avatar Jul 03 '25 11:07 middt

@middt - Appreciate this amazing contribution to Dapr! Would love to get this to be a stable component in due course.

@msfussell – Thank you so much for the approval and kind words! 🙌

middt avatar Jul 09 '25 15:07 middt

@middt - can you remove the sdkdoc/python file from the PR. This should not be here, otherwise cannot merge

msfussell avatar Aug 29 '25 03:08 msfussell

msfussell

@msfussell ✅ Done! Removed sdkdocs/python and all other unnecessary files. The PR now contains only the 2 ClickHouse files. Thanks for catching that!

middt avatar Aug 31 '25 03:08 middt

@middt I've resolved a merge conflict in genericl.yaml since the query property does not exist any longer. I've set the workflow property to false. Can you confirm if this is correct?

marcduiker avatar Sep 10 '25 13:09 marcduiker

@middt I've resolved a merge conflict in genericl.yaml since the query property does not exist any longer. I've set the workflow property to false. Can you confirm if this is correct?

Yes, setting workflow: false is correct — good catch! Thanks for the fix! ✅ — @marcduiker

middt avatar Sep 11 '25 07:09 middt