Initial Dapr Shared Docs
Please follow this checklist before submitting:
- [x] Commits are signed with Developer Certificate of Origin (DCO - learn more)
- [x] Read the contribution guide
- [x] Commands include options for Linux, MacOS, and Windows within codetabs
- [x] New file and folder names are globally unique
- [ ] Page references use shortcodes instead of markdown or URL links
- [x] Images use HTML style and have alternative text
- [ ] Places where multiple code/command options are given have codetabs
In addition, please fill out the following to help reviewers understand this pull request:
Description
This is an initial version of the Dapr Shared docs. Now that Dapr Shared is out of Sandbox, a new set of docs are needed for new users to understand how to use it and get started with Dapr Shared. I would appreciate feedback on the location of these docs and what other sections to include.
Issue reference
@salaboy - @msfussell suggested I update the diagrams and send you the slides in case you wanted to tweak. Here's the pptx link:
@salaboy - @msfussell suggested I update the diagrams and send you the slides in case you wanted to tweak. Here's the pptx link:
Thanks a lot for doing this @hhunter-ms ! the diagrams look amazing
@hhunter-ms there are a few things that I need to manually change.. but the rest looks good.. I will tackle these changes in the next few days.
Stale PR, paging all reviewers
Stale PR, paging all reviewers
Stale PR, paging all reviewers
@salaboy - Tell me when you have time to review these comments to that we can get the PR merged. Suggest getting changes to the Dapr-Shared repo at the same time
Stale PR, paging all reviewers
bump.. working on this now
Ok, quick update here.
To get this done, I needed to change the hello-kubernetes quickstart applications to support the SDK supported environment variables: https://github.com/dapr/quickstarts/issues/1029 and https://github.com/dapr/quickstarts/pull/1030
Once these changes are done, I am submitting a PR to the dapr-shared repository with a new tutorial expanding on the hello-kubernetes tutorial to use Dapr Shared.
Finally, I will align this PR to link to that tutorial and maybe use the diagrams shown there.
@msfussell @hhunter-ms I think the daemonset diagram is fine, as the note explicitly says one per cluster node..
quick grammar review
Thanks a lot @hhunter-ms !
@msfussell diagrams updated.. I tried to answer all your comments but can we please not change the terminology and use Deployment and DaemonSet strategies? I think we will confuse people
@msfussell diagrams updated.. I tried to answer all your comments but can we please not change the terminology and use Deployment and DaemonSet strategies? I think we will confuse people
@salaboy - Diagram look good. Where is the source for the diagrams? Can you provide these? And one ask on the diagrams is to add the Kubernetes logo to show the boundary of the cluster. Like this example https://docs.dapr.io/concepts/overview/#kubernetes
New diagrams here: Dapr-Shared-diagrams.pptx based on what @hhunter-ms shared with me
Done
-
Blog: http://salaboy.com http://salaboy.wordpress.com
-
Github user: http://github.com/salaboy
-
Twitter: http://twitter.com/salaboy
-
Mauricio "Salaboy" Salatino -
On Thu, 27 Jun 2024 at 16:55, Hannah Hunter @.***> wrote:
@.**** commented on this pull request.
@salaboy https://github.com/salaboy - could you "Ignore all" the spelling error in the daemonset.png diagram to remove the red squiggly lines? other than that, lgtm!
— Reply to this email directly, view it on GitHub https://github.com/dapr/docs/pull/4121#pullrequestreview-2145835699, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACCMXVCF4WMEAFQN7OYJG3ZJQYX3AVCNFSM6AAAAABG6LU66CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNBVHAZTKNRZHE . You are receiving this because you were mentioned.Message ID: @.***>
@holopin-bot @salaboy Thanks Salaboy!
Congratulations @salaboy, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzv8o9wf164060clcsdjvmvli
This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!