dapr icon indicating copy to clipboard operation
dapr copied to clipboard

[Tracking issue] Dapr Workflows Stable

Open olitomlinson opened this issue 1 year ago • 22 comments

This issue will be the source of truth for collating all tasks what must be complete in order for Workflows to progress to Stable, for the 1.15 release.

Dapr Runtime / durabletask-go

  • [ ] [P0] Scheduler moving to being the default, tracking issue here
    • [ ] Migration - State -> Scheduler reminders
  • [x] [P0] https://github.com/dapr/dapr/issues/8085
  • [x] [P0] https://github.com/dapr/dapr/issues/7749
  • [x] [P0] https://github.com/dapr/dapr/issues/6889
  • [x] [P0] https://github.com/dapr/dapr/issues/7777
  • [ ] [P0] https://github.com/dapr/dapr/issues/7824
  • [x] [P0] https://github.com/dapr/dotnet-sdk/issues/1205
  • [ ] [P0] https://github.com/dapr/dapr/issues/8277
  • [ ] [P1] https://github.com/dapr/dapr/issues/7927
  • [ ] [P1] https://github.com/dapr/dapr/issues/6014
  • [ ] [P1] https://github.com/dapr/dapr/issues/7633
  • [ ] [P2] https://github.com/dapr/dapr/issues/7934
  • [ ] [P2] https://github.com/dapr/dapr/issues/7706
  • [ ] [P2] https://github.com/dapr/dapr/issues/8088

Contrib / State Store

  • [ ] [P0] [AzureSQL] https://github.com/dapr/dapr/issues/7570

Quickstarts

  • [x] https://github.com/dapr/dotnet-sdk/issues/1234

Perf

  • [ ]

Docs

  • [ ] https://github.com/dapr/dapr/issues/6475

SDKs

.NET SDK

  • [x] [P0] https://github.com/dapr/dotnet-sdk/issues/1344
  • [ ] [P0] https://github.com/dapr/dotnet-sdk/issues/1293
  • [ ] [P0] https://github.com/dapr/dapr/issues/8086
  • [ ] [P0] https://github.com/dapr/dotnet-sdk/issues/1216
  • [x] [P0] https://github.com/dapr/dotnet-sdk/issues/1215
  • [x] [P0] https://github.com/dapr/dotnet-sdk/issues/1203
  • [x] [P0] https://github.com/dapr/dotnet-sdk/issues/1163 (also requires runtime work)
  • [ ] [P1] https://github.com/dapr/dotnet-sdk/issues/1118
  • [ ] [P1] https://github.com/dapr/dotnet-sdk/issues/1220
  • [ ] [P1] https://github.com/dapr/dotnet-sdk/issues/1200
  • [x] [P1] https://github.com/dapr/dotnet-sdk/pull/1244 (PR that needs to be reviewed/merged)
  • [ ] [P2] https://github.com/dapr/dotnet-sdk/issues/1225

Java SDK

  • [ ] [P????] https://github.com/dapr/java-sdk/issues/1155
  • [ ] [P0] https://github.com/dapr/java-sdk/issues/1012
  • [ ] [P1] https://github.com/dapr/java-sdk/issues/991
  • [ ] [P1] https://github.com/dapr/java-sdk/issues/980
  • [ ] [P1] https://github.com/dapr/java-sdk/issues/966
  • [ ] [P1] https://github.com/dapr/java-sdk/issues/905

JavaScript SDK / durabletask_js - thank you @famarting

  • [x] https://github.com/dapr/js-sdk/issues/643
  • [x] https://github.com/microsoft/durabletask-js/issues/64 (requires counterpart change in dapr sdk)
  • [ ] https://github.com/microsoft/durabletask-js/issues/47 (requires counterpart change in dapr sdk)
  • [ ] https://github.com/microsoft/durabletask-js/issues/30 (requires counterpart change in dapr sdk)
  • [ ] https://github.com/microsoft/durabletask-js/issues/13 (requires counterpart change in dapr sdk)
  • [x] https://github.com/dapr/js-sdk/issues/638
  • [x] https://github.com/dapr/js-sdk/issues/639

Go SDK - thank you @famarting

  • [ ] https://github.com/dapr/go-sdk/issues/611
  • [x] https://github.com/dapr/go-sdk/issues/541
  • [x] https://github.com/dapr/go-sdk/issues/634
  • [x] https://github.com/dapr/go-sdk/issues/493
  • [x] https://github.com/dapr/go-sdk/issues/497
  • [x] https://github.com/dapr/go-sdk/issues/635
  • [ ] https://github.com/dapr/go-sdk/issues/636
  • [x] https://github.com/microsoft/durabletask-go/pull/83

Python SDK - thank you @famarting

  • [x] https://github.com/dapr/python-sdk/issues/655
  • [x] https://github.com/dapr/python-sdk/issues/738
  • [x] https://github.com/dapr/python-sdk/issues/739
  • [x] https://github.com/dapr/python-sdk/issues/740
  • [x] https://github.com/dapr/python-sdk/issues/711

Deferred / Not essential for Stable

  • https://github.com/dapr/dapr/issues/3417
  • [CosmosDb] https://github.com/dapr/dapr/issues/7321
  • https://github.com/dapr/dapr/issues/8243
  • https://github.com/dapr/java-sdk/issues/1156
  • https://github.com/dapr/python-sdk/issues/748
  • ~~https://github.com/microsoft/durabletask-python/issues/32~~
  • https://github.com/dapr/durabletask-python/issues/4
  • https://github.com/dapr/js-sdk/issues/657 (requires counterpart change in dapr/durabletask-js)

olitomlinson avatar Aug 18 '24 20:08 olitomlinson

Hello, this keeps happening. https://github.com/dapr/dapr/issues/7824 @olitomlinson

arturotrenard avatar Sep 01 '24 15:09 arturotrenard

@dapr/approvers-dotnet-sdk @dapr/maintainers-dotnet-sdk - Are all of these SDK issues proportionate, necessary, appropriate and is there bandwidth to get them completed for workflows to be stable?

mikeee avatar Sep 04 '24 12:09 mikeee

@mikeee I wasn't clear btw, I fully expect the above list to be triaged for suitability by the maintainers for what is in and out of scope for 1.15 :)

olitomlinson avatar Sep 04 '24 12:09 olitomlinson

@mikeee I wasn't clear btw, I fully expect the above list to be triaged for suitability by the maintainers for what is in and out of scope for 1.15 :)

Thought so, I'll await the dotnet-sdk maintainers to triage the SDK items

mikeee avatar Sep 04 '24 12:09 mikeee

I'll be helping out with the triage of these items over the next few days.

cgillum avatar Sep 06 '24 21:09 cgillum

@olitomlinson I think https://github.com/dapr/dapr/issues/3417 might be referring to GitHub actions workflows and not Dapr Workflow. If you agree, then we can probably take it off this list.

cgillum avatar Sep 12 '24 01:09 cgillum

I went ahead and added [P_] next to the above issues for us to better see what work is a P0 for this release

cicoyle avatar Sep 12 '24 19:09 cicoyle

@cgillum this should probably go on the list too right? (And fixes for all other language SDKS)

https://github.com/dapr/dapr/issues/7218 / https://github.com/dapr/dotnet-sdk/pull/1244

olitomlinson avatar Sep 24 '24 20:09 olitomlinson

@olitomlinson @cgillum I'll be going through the go, python and javascript SDKs to review the different changes we need pursuing SDK parity and workflows to become stable

So far this is a list of issue for the go sdk that I believe should be tracked here:


Oli : Moved items into main post

famarting avatar Oct 10 '24 12:10 famarting

Here are the issues for the python SDK, notice the issues that are closed should be re-opened


Oli : Moved items into main post

famarting avatar Oct 10 '24 12:10 famarting

And the js sdk issues, the durabletask-js issues would need their counterpart issues created in the js-sdk repo:


Oli : Moved items into main post

famarting avatar Oct 10 '24 13:10 famarting

@olitomlinson The top P0 item in the .NET SDK referencing https://github.com/dapr/dotnet-sdk/issues/1344 can be marked off as completed.

So can the P0 item referencing an Unknown status referencing https://github.com/dapr/dotnet-sdk/issues/1215

WhitWaldo avatar Oct 14 '24 20:10 WhitWaldo

Added prioritized list of Java SDK issues to the OP.

cgillum avatar Oct 15 '24 20:10 cgillum

@olitomlinson I'd like to propose adding https://github.com/dapr/dapr/issues/7321 to the stabilization list as it's a named issue on the Workflow Limitations, but the issue was closed due to staleness.

WhitWaldo avatar Oct 17 '24 15:10 WhitWaldo

I've discovered that the workflow SDKs are inconsistent in the naming of callChildWorkflow / callSubWorkflow

  • dotnet, go, and python use callChildWorkflow
  • java and javascript use callSubWorkflow

I believe the SDKs should strive for consistency where sensible, and should strive to be consistent with the docs which only refers to child workflows

I've raised tickets to bring the Java and JS SDKs inline with the others :

  • https://github.com/dapr/java-sdk/issues/1155
  • https://github.com/dapr/js-sdk/issues/643

I believe these would both be considered P0 as we want to go into the Stable release with method names that won't change.

Thoughts @yaron2 @artursouza ?

olitomlinson avatar Oct 29 '24 00:10 olitomlinson

@olitomlinson I'd like to propose adding #7321 to the stabilization list as it's a named issue on the Workflow Limitations, but the issue was closed due to staleness.

I agree. I've reopened this and added this to the main list.

@cgillum what priority should be attached to this item? Are we intending to ship with CosmosDb support in 1.15?

olitomlinson avatar Oct 29 '24 00:10 olitomlinson

@olitomlinson per an earlier discussion with @yaron2, I think the best path forward is to have a list of supported state stores for workflow, similar to actors (it would necessarily be a subset of actor state stores). Cosmos DB and similar state stores would not be on that list due to the issue you linked to. Unfortunately, I think there isn't enough time to work through those issues before Stable.

cgillum avatar Oct 29 '24 12:10 cgillum

@cgillum Is there an issue somewhere that tracks progress of the NoSQL support and what's lacking?

WhitWaldo avatar Oct 29 '24 12:10 WhitWaldo

@WhitWaldo I don't believe we have an issue tracking progress of this work. However, I do have an old PR that does the foundational work in the durabletask-go dependency to enable it: https://github.com/microsoft/durabletask-go/pull/50 ("state update chunking"). The main problem has been finding the time to validate and stabilize it.

cgillum avatar Oct 29 '24 12:10 cgillum

@olitomlinson Possible additions to the list following the discussion in #Workflow by @NunzioCar:

https://github.com/dapr/dapr/issues/8322 https://github.com/dapr/dapr/issues/8323

WhitWaldo avatar Dec 01 '24 23:12 WhitWaldo

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

dapr-bot avatar May 09 '25 15:05 dapr-bot

This issue has been automatically closed because it has not had activity in the last 67 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

dapr-bot avatar May 16 '25 15:05 dapr-bot

This issue has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions.

dapr-bot avatar Nov 02 '25 22:11 dapr-bot

This issue has been automatically closed because it has not had activity in the last 97 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue, help wanted or triaged/resolved. Thank you for your contributions.

dapr-bot avatar Nov 09 '25 23:11 dapr-bot