dapr icon indicating copy to clipboard operation
dapr copied to clipboard

Enable Dapr-to-app communication when apps are behind a firewall

Open ItalyPaleAle opened this issue 2 years ago • 8 comments

Description

The problem this PR tries to solve is to enable apps to receive messages from Dapr without the need for a listener, so they can work even behind a firewall.

For an initial discussion, please see the issue this PR fixes: #5392

A full demo is available at: ItalyPaleAle/dapr-firewall-poc

Please also see a description of how this works in that page: https://github.com/ItalyPaleAle/dapr-firewall-poc#implementation-details

In order for this PR to work, each Dapr SDK will need to be updated to support the new way of connecting to Dapr too.

Issue reference

Fixes #5392

SDKs

  • Go: https://github.com/dapr/go-sdk/pull/350

ItalyPaleAle avatar Jan 09 '23 23:01 ItalyPaleAle

Codecov Report

Attention: 147 lines in your changes are missing coverage. Please review.

Comparison is base (6fbc245) 64.63% compared to head (f960ca5) 64.23%. Report is 718 commits behind head on master.

Files Patch % Lines
pkg/runtime/runtime.go 16.27% 33 Missing and 3 partials :warning:
pkg/grpc/grpc.go 0.00% 29 Missing :warning:
pkg/channel/grpc/grpc_channel.go 0.00% 27 Missing :warning:
pkg/grpc/api_connectappcallback.go 0.00% 14 Missing :warning:
pkg/injector/sidecar/container.go 50.00% 11 Missing and 2 partials :warning:
pkg/runtime/app_callback_listener.go 73.46% 8 Missing and 5 partials :warning:
pkg/runtime/cli.go 0.00% 13 Missing :warning:
pkg/grpc/server.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5731      +/-   ##
==========================================
- Coverage   64.63%   64.23%   -0.41%     
==========================================
  Files         180      182       +2     
  Lines       17850    18040     +190     
==========================================
+ Hits        11538    11588      +50     
- Misses       5397     5528     +131     
- Partials      915      924       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 10 '23 00:01 codecov[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar May 30 '23 16:05 dapr-bot

👋🤖

ItalyPaleAle avatar May 30 '23 17:05 ItalyPaleAle

Indeed, it is a potential issue that could exist in reality.

xckai avatar Aug 09 '23 03:08 xckai

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Oct 08 '23 03:10 dapr-bot

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Dec 07 '23 03:12 dapr-bot

keep-alive

ItalyPaleAle avatar Dec 07 '23 05:12 ItalyPaleAle

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Feb 05 '24 06:02 dapr-bot