dapr icon indicating copy to clipboard operation
dapr copied to clipboard

Add Initial http bulk subscribe Implementation

Open DeepanshuA opened this issue 3 years ago • 3 comments

Signed-off-by: Deepanshu Agarwal [email protected]

Description

It implements http bulk subscribe implementation in runtime.

Issue reference

Please reference the issue this PR will close: #2218

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Unit tests passing
  • [ ] End-to-end tests passing
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
  • [ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
  • [ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

DeepanshuA avatar Sep 12 '22 17:09 DeepanshuA

Codecov Report

Merging #5154 (6571012) into feature/pubsub-batching (76c27bf) will decrease coverage by 0.50%. The diff coverage is 49.13%.

@@                     Coverage Diff                     @@
##           feature/pubsub-batching    #5154      +/-   ##
===========================================================
- Coverage                    66.42%   65.92%   -0.51%     
===========================================================
  Files                          127      130       +3     
  Lines                        13414    13865     +451     
===========================================================
+ Hits                          8910     9140     +230     
- Misses                        3882     4085     +203     
- Partials                       622      640      +18     
Impacted Files Coverage Δ
pkg/runtime/pubsub/bulksubscribe_events.go 0.00% <0.00%> (ø)
pkg/runtime/pubsub/bulksub.go 25.00% <25.00%> (ø)
pkg/diagnostics/component_monitoring.go 84.87% <48.38%> (-6.51%) :arrow_down:
pkg/runtime/runtime.go 68.18% <50.64%> (+0.27%) :arrow_up:
pkg/runtime/bulk_subscriber.go 55.82% <55.82%> (ø)
pkg/components/pubsub/pluggable.go 74.35% <0.00%> (+5.12%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 12 '22 19:09 codecov[bot]

FYI made changes in a PR against this PR: https://github.com/DeepanshuA/dapr/pull/29

ItalyPaleAle avatar Sep 20 '22 18:09 ItalyPaleAle

FYI made changes in a PR against this PR: DeepanshuA#29

thanks @ItalyPaleAle , for taking care of these Misc fixes.

DeepanshuA avatar Sep 20 '22 18:09 DeepanshuA