dapr icon indicating copy to clipboard operation
dapr copied to clipboard

log warning when error connecting to placement service

Open patrickxiong opened this issue 3 years ago • 2 comments

Signed-off-by: Patrick.Xiong [email protected]

Description

Change the log level from debug to warn when error connecting to placement service

Issue reference

Please reference the issue this PR will close: #2896

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [ ] Created/updated tests
  • [x] Unit tests passing
  • [ ] End-to-end tests passing
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
  • [ ] Specification has been updated / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
  • [ ] Provided sample for the feature / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

patrickxiong avatar Jan 10 '22 07:01 patrickxiong

Codecov Report

Merging #4110 (de1c43e) into master (c63be2f) will decrease coverage by 0.06%. The diff coverage is 100.00%.

:exclamation: Current head de1c43e differs from pull request most recent head 7d95ec3. Consider uploading reports for the commit 7d95ec3 to get more accurate results

@@            Coverage Diff             @@
##           master    #4110      +/-   ##
==========================================
- Coverage   64.79%   64.72%   -0.07%     
==========================================
  Files         111      111              
  Lines       12157    12040     -117     
==========================================
- Hits         7877     7793      -84     
+ Misses       3712     3682      -30     
+ Partials      568      565       -3     
Impacted Files Coverage Δ
pkg/actors/internal/placement.go 87.56% <100.00%> (ø)
pkg/operator/handlers/dapr_handler.go 64.70% <0.00%> (-4.98%) :arrow_down:
pkg/grpc/proxy/codec/codec.go 88.88% <0.00%> (-4.45%) :arrow_down:
pkg/grpc/proxy/handler.go 70.00% <0.00%> (-3.00%) :arrow_down:
pkg/injector/pod_patch.go 91.94% <0.00%> (-0.06%) :arrow_down:
pkg/messaging/direct_messaging.go 18.75% <0.00%> (ø)
pkg/http/api.go 74.98% <0.00%> (+0.01%) :arrow_up:
pkg/grpc/api.go 72.78% <0.00%> (+0.09%) :arrow_up:
pkg/runtime/runtime.go 69.00% <0.00%> (+0.11%) :arrow_up:
pkg/runtime/pubsub/subscriptions.go 70.08% <0.00%> (+0.13%) :arrow_up:
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Jan 11 '22 04:01 codecov[bot]

This will result in a swarm of error messages showing every 500ms. Do we want that?

cc @artursouza

yaron2 avatar Mar 18 '22 22:03 yaron2

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Sep 30 '22 16:09 dapr-bot

This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Oct 07 '22 16:10 dapr-bot