components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard
verified publisher icon dapr

Adds Global TTL Configuration for DynamoDB State Store

Open ZeynelKoca opened this issue 2 months ago • 15 comments

Description

Adds a way to globally configure the state TTL for dynamo (inspired by #1059).

The defined default TTL will only be used if the state request does not explicitly specify a TTL itself.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [x] Extended the documentation
    • [x] Created the dapr/docs PR: https://github.com/dapr/docs/pull/4911

ZeynelKoca avatar Oct 06 '25 13:10 ZeynelKoca

Would be nice when the different statestores (Redis and Dynamo) behave in a similar way.

JoostPV avatar Oct 16 '25 12:10 JoostPV

There will be a slight delay in reviewing the DynamoDB-related PRs. We need to address the missing/disabled tests first, which are being tracked in issue #4047. Thanks for your patience!

MyMirelHub avatar Oct 20 '25 14:10 MyMirelHub

@sicoyle Ready for another review round

ZeynelKoca avatar Oct 27 '25 10:10 ZeynelKoca

one last comment and then this LGTM - thank you!

Fixed. Also updated the docs PR with the same description

ZeynelKoca avatar Oct 28 '25 08:10 ZeynelKoca

@ZeynelKoca pls see the build failures and ping when you're ready and I can retrigger 🙏

sicoyle avatar Oct 30 '25 14:10 sicoyle

@sicoyle Fixed a stupid rebase mistake. Try again?

ZeynelKoca avatar Oct 30 '25 14:10 ZeynelKoca

@sicoyle Can the pipeline run get an approval?

ZeynelKoca avatar Nov 18 '25 09:11 ZeynelKoca

@sicoyle Fixed the formatting 🙏

ZeynelKoca avatar Nov 18 '25 16:11 ZeynelKoca

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

ZeynelKoca avatar Nov 19 '25 08:11 ZeynelKoca

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

rerunning, lets see. I know github has been having quite a few issues recently

sicoyle avatar Nov 20 '25 15:11 sicoyle

@sicoyle I think a re-run is needed? Pipelines failed due to being unable to checkout the repo

rerunning, lets see. I know github has been having quite a few issues recently

Fixed another formatting issue 🙏

ZeynelKoca avatar Nov 20 '25 17:11 ZeynelKoca

@sicoyle Can you trigger a pipeline run? I see that the corresponding docs PR has already been merged.

ZeynelKoca avatar Dec 04 '25 14:12 ZeynelKoca

@sicoyle Thanks! The build failed again due to formatting issues (🙄) so I upgraded to the exact go version the pipeline was using. go fmt now properly added the missing new-line at the end of the dynamodb_test.go file. Another pipeline run should do it 🤞

ZeynelKoca avatar Dec 09 '25 23:12 ZeynelKoca

The build failed again due to formatting issues (🙄)

LOL I feel this 😄 It's running. Will circle back later today and if all green we can send it 🚀

sicoyle avatar Dec 10 '25 14:12 sicoyle

@sicoyle No formatting issues anymore 🎉

1 failing unit test though, which I updated based on the new TTL property behavior. All tests pass now locally

ZeynelKoca avatar Dec 10 '25 18:12 ZeynelKoca