components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Add coherence state store component - updated

Open tmiddlet2666 opened this issue 6 months ago • 3 comments

Description

Added a new implementation for a Coherence state store component.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [x] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#4661

tmiddlet2666 avatar Jun 05 '25 03:06 tmiddlet2666

Hi @JoshVanL @daixiang0 Creating this new PR to replace the old one which i will close. There were too many conflicts in my manual merge

tmiddlet2666 avatar Jun 05 '25 03:06 tmiddlet2666

Hi @JoshVanL @daixiang0 Anything more i need to do here, thanks?

tmiddlet2666 avatar Jun 10 '25 09:06 tmiddlet2666

Thanks @nelson-parente I have pushed updated code to address review comments.

tmiddlet2666 avatar Jun 17 '25 02:06 tmiddlet2666

@JoshVanL @daixiang0 Please let me know if any more changes are required now @nelson-parente has approved Thanks

tmiddlet2666 avatar Jun 20 '25 00:06 tmiddlet2666

Any more changes required here? Can we can this approved and merged please? Thanks

tmiddlet2666 avatar Jun 24 '25 23:06 tmiddlet2666

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: https://github.com/dapr/docs/pull/4691

yaron2 avatar Jun 26 '25 15:06 yaron2

@tmiddlet2666 Please follow up with a docs PR to add this to our docs. See an example here: dapr/docs#4691

Thanks @yaron2 I have created a doc issue for my previous PR https://github.com/dapr/docs/issues/4661 Will look at the above example. Thanks

tmiddlet2666 avatar Jun 26 '25 23:06 tmiddlet2666