components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

feat: support subscribeMode field on pulsar

Open ericsyh opened this issue 7 months ago • 8 comments

Description

Please explain the changes you've made

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: https://github.com/dapr/components-contrib/issues/3832

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [x] Extended the documentation with https://github.com/dapr/docs/pull/4663

ericsyh avatar May 22 '25 15:05 ericsyh

@ericsyh - Is there an issue number for this PR?

msfussell avatar May 24 '25 05:05 msfussell

@ericsyh - Is there an issue number for this PR?

@msfussell sorry i missed the issue create before, just created a new issue of https://github.com/dapr/components-contrib/issues/3832 and linked on this PR.

ericsyh avatar May 24 '25 13:05 ericsyh

@nelson-parente @mikeee Could you help review again? cc @yaron2 @JoshVanL help review

ericsyh avatar Jun 01 '25 02:06 ericsyh

Looks like a minor linter issue popped up if you could please address it :)

mikeee avatar Jun 11 '25 11:06 mikeee

Looks like a minor linter issue popped up if you could please address it :)

@mikeee I just fixed the lint in the https://github.com/dapr/components-contrib/pull/3831/commits/14f449dad86a9116d847825a5f30ea31f0070960, now it should be fine.

ericsyh avatar Jun 11 '25 12:06 ericsyh

@nelson-parente @msfussell PTAL the updated PR thx.

ericsyh avatar Jun 13 '25 06:06 ericsyh

@yaron2 I think this is good to merge

nelson-parente avatar Jun 13 '25 11:06 nelson-parente

The lint and several comformance check fail in the merge-quege CI was not caused by my changes...

ericsyh avatar Jun 14 '25 08:06 ericsyh

@yaron2 Hi Yaron, the merge queue was failed but it looks not caused by this PR, anything need change from this PR?

[/home/runner/work/components-contrib/components-contrib] ...
  common/authentication/aws/x509.go:162:14       staticcheck  SA1019: spiffecontext.From is deprecated: use FromX509 instead. From retrieves the x509 SVID source from the context. 
  common/authentication/aws/x509_test.go:120:10  staticcheck  SA1019: spiffecontext.With is deprecated: use WithX509 instead. With adds the x509 SVID source from the SPIFFE object to the context. 
  middleware/http/opa/middleware.go:32:2         staticcheck  SA1019: "github.com/open-policy-agent/opa/rego" is deprecated: This package is intended for older projects transitioning from OPA v0.x and will remain for the lifetime of OPA v1.x, but its use is not recommended. For newer features and behaviours, such as defaulting to the Rego v1 syntax, use the corresponding components in the [github.com/open-policy-agent/opa/v1] package instead. See https://www.openpolicyagent.org/docs/latest/v0-compatibility/ for more information. 

ericsyh avatar Jun 20 '25 23:06 ericsyh