dapr
Add option to ser/deser avro to/from AvroJSON if the component is configured to do so.
Description
Add option to ser/deser avro to/from AvroJSON if the component is configured to do so.
Issue reference
Please reference the issue this PR will close: dapr/components-contrib#3721
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Hey @passuied - I transferred the issue over and assigned it to you. Thank you for your efforts 🎉 Mind resolving the linter issues?
@JoshVanL @cicoyle any next steps on this PR? I could update the branch but without reviews it feels moot...
@passuied looks like CI is very red with this PR - can you fix linter and see if the issues arise from the diff from this PR?
lgtm - @passuied mind opening a dapr/docs PR with this new field
useAvroJSONdocumented?
Done! Thanks for reviewing. Please let me know what's the next step for getting it merged. @JoshVanL since you requested a change, you may need to approve it first ;)
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@cicoyle @passuied @JoshVanL any news? This issue blocks our current development and for some topics we have to switch back to Kafka client instead of using Dapr Kafka PubSub. Thank you.
@cicoyle @passuied @JoshVanL any news? This issue blocks our current development and for some topics we have to switch back to Kafka client instead of using Dapr Kafka PubSub. Thank you.
I'm waiting for PR approval. I believe that given the time, it won't get pulled into 1.16 as the release branch is already out...
@passuied Please open a PR in the docs for this change
@yaron2 the docs PR had already gone through somehow. I see it in 1.16. Might need to revert the docs if this is only going out in 1.17