components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

bugfix for redis json check

Open theonefx opened this issue 9 months ago • 4 comments

In the Multi method of the state Redis component, when checking whether a request is in JSON format, if the item in the request has contentType=application/json explicitly set, the check will pass. This results in the JSON processing logic being triggered even if clientHasJSON (a flag indicating whether the client supports JSON) is not enabled.

theonefx avatar Mar 13 '25 09:03 theonefx

@yaron2

theonefx avatar Mar 13 '25 09:03 theonefx

Thanks @theonefx , please can we add a certification test to cover this fix?

done

theonefx avatar Mar 14 '25 06:03 theonefx

/test

theonefx avatar Mar 27 '25 09:03 theonefx

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 26 '25 11:04 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jun 21 '25 14:06 github-actions[bot]

@theonefx - mind reviewing the components cert test in CI for the state.redis run? It looks to be failing and might be related to the diff in this PR.

cicoyle avatar Jun 25 '25 20:06 cicoyle

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Jul 25 '25 20:07 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Aug 01 '25 20:08 github-actions[bot]