components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

fix(cert test): bump cert test deps to match main go mod ones

Open sicoyle opened this issue 1 year ago • 1 comments

Description

I keep seeing an issue in my other PR bc of these dependencies. Want to separate the fix to here. https://github.com/dapr/components-contrib/pull/3324

rror: /home/runner/go/pkg/mod/github.com/dapr/[email protected]/pkg/runtime/hotreload/loader/disk/resource.go:33:21: not enough type arguments for type Batcher: have 1, want 2
Error: /home/runner/go/pkg/mod/github.com/dapr/[email protected]/pkg/runtime/hotreload/loader/disk/resource.go:48:31: cannot infer T (/home/runner/go/pkg/mod/github.com/dapr/[email protected]/events/batcher/batcher.go:50:24)

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

sicoyle avatar May 03 '24 21:05 sicoyle

You have to run make modtidy-all for linter and build to pass.

berndverst avatar May 03 '24 23:05 berndverst

Any update here?

berndverst avatar Jun 11 '24 23:06 berndverst

dropping in favor of https://github.com/dapr/components-contrib/pull/3390

sicoyle avatar Jun 21 '24 18:06 sicoyle