components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Investigate Azure Service Bus concurrent session handling

Open jjcollinge opened this issue 1 year ago • 7 comments

Signed-off-by: Joni Collinge [email protected]

Description

Adds new certificate test for using sessions with the Azure Service Bus Topics PubSub component. I added this when trying to reproduce the behavior reported in the following issue: https://github.com/dapr/components-contrib/issues/3281. The test does not reproduce the issue but does add better coverage for concurrent session processing. The original issue may be linked to an invalid session ID being used so I've also added some simple validation on the session ID and message ID properties on a message.

This PR relies on the changes made here: https://github.com/dapr/go-sdk/pull/490

Issue reference

Please reference the issue this PR will close: https://github.com/dapr/components-contrib/issues/3281

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

jjcollinge avatar Jan 02 '24 14:01 jjcollinge

/ok-to-test

ItalyPaleAle avatar Jan 03 '24 17:01 ItalyPaleAle

Components certification test

🔗 Link to Action run

Commit ref: 6592bfa8c353d7502bd2f0ad5f8eec8905bb3882

❌ Some certification tests failed

These tests failed:

  • pubsub.azure.eventhubs
  • pubsub.azure.servicebus.topics

dapr-bot avatar Jan 03 '24 17:01 dapr-bot

Complete Build Matrix

The build status is currently not updated here. Please visit the action run below directly.

🔗 Link to Action run

Commit ref: 6592bfa8c353d7502bd2f0ad5f8eec8905bb3882

dapr-bot avatar Jan 03 '24 17:01 dapr-bot

Components conformance test

🔗 Link to Action run

Commit ref: 6592bfa8c353d7502bd2f0ad5f8eec8905bb3882

❌ Some conformance tests failed

These tests failed:

  • state.azure.cosmosdb
  • state.postgresql.v1.azure

dapr-bot avatar Jan 03 '24 17:01 dapr-bot

@ItalyPaleAle just to make you aware this PR relies on this change in the Go SDK https://github.com/dapr/go-sdk/pull/490 - once that is merged I can bump this PR.

jjcollinge avatar Jan 03 '24 17:01 jjcollinge

@ItalyPaleAle just to make you aware this PR relies on this change in the Go SDK dapr/go-sdk#490 - once that is merged I can bump this PR.

Sounds good. I'll move the PR to draft then until that is ready

ItalyPaleAle avatar Jan 03 '24 17:01 ItalyPaleAle

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Feb 08 '24 08:02 github-actions[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Mar 09 '24 09:03 github-actions[bot]

👋

jjcollinge avatar Mar 09 '24 13:03 jjcollinge

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 08 '24 13:04 github-actions[bot]

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

github-actions[bot] avatar Apr 15 '24 13:04 github-actions[bot]