components-contrib
components-contrib copied to clipboard
Add pubsub rabbitmq TTL support
Description
Add pubsub rabbitmq TTL support. Add a queue level TTL metadata, which can be rewritten by metadata defined in each call.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #2072
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#2808
Codecov Report
Merging #2093 (150bada) into master (acb51bb) will increase coverage by
0.06%
. The diff coverage is20.00%
.
@@ Coverage Diff @@
## master #2093 +/- ##
==========================================
+ Coverage 38.15% 38.22% +0.06%
==========================================
Files 197 197
Lines 25188 25207 +19
==========================================
+ Hits 9611 9635 +24
+ Misses 14821 14805 -16
- Partials 756 767 +11
Impacted Files | Coverage Δ | |
---|---|---|
pubsub/rabbitmq/metadata.go | 90.55% <14.28%> (-4.45%) |
:arrow_down: |
pubsub/rabbitmq/rabbitmq.go | 55.61% <23.07%> (-1.00%) |
:arrow_down: |
nameresolution/mdns/mdns.go | 73.48% <0.00%> (-0.34%) |
:arrow_down: |
configuration/azure/appconfig/appconfig.go | 73.93% <0.00%> (+9.40%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
/ok-to-test
Components conformance test
Commit ref: f5bb6b3ea09af4ea53265e941a8f7d6450a50e24
✅ All conformance tests passed
All tests have reported a successful status
Components certification test
Commit ref: f5bb6b3ea09af4ea53265e941a8f7d6450a50e24
❌ Some certification tests failed
These tests failed:
- pubsub.rabbitmq
Certification tests passed, this pr is ready for review now.
@mukundansundar please re-review.