components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Adds support for Redis 7 via `redisVersion` metadata in all redis components

Open berndverst opened this issue 3 years ago • 2 comments

Description

Adds support for Redis 7 via redisVersion metadata in all redis components

When setting redisVersion to 7 / v7 or greater the new Redis Go SDK v9 will be used. For Redis 6 and below the v8 SDK will be used.

Issue reference

#1909

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [x] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

berndverst avatar Sep 15 '22 21:09 berndverst

Codecov Report

Merging #2085 (6acc590) into master (595e448) will decrease coverage by 0.33%. The diff coverage is 16.71%.

:exclamation: Current head 6acc590 differs from pull request most recent head 1608281. Consider uploading reports for the commit 1608281 to get more accurate results

@@            Coverage Diff             @@
##           master    #2085      +/-   ##
==========================================
- Coverage   37.86%   37.52%   -0.34%     
==========================================
  Files         193      193              
  Lines       24554    24721     +167     
==========================================
- Hits         9297     9277      -20     
- Misses      14543    14663     +120     
- Partials      714      781      +67     
Impacted Files Coverage Δ
internal/component/redis/metadata.go 0.00% <0.00%> (ø)
internal/component/redis/redis.go 0.00% <0.00%> (ø)
state/redis/redis_query.go 47.87% <0.00%> (-2.77%) :arrow_down:
pubsub/redis/redis.go 12.50% <6.31%> (-7.66%) :arrow_down:
bindings/redis/redis.go 16.94% <18.75%> (+2.24%) :arrow_up:
lock/redis/standalone.go 39.88% <33.33%> (-13.11%) :arrow_down:
state/redis/redis.go 34.94% <36.74%> (+0.09%) :arrow_up:
configuration/azure/appconfig/appconfig.go 41.89% <0.00%> (-22.64%) :arrow_down:
secretstores/gcp/secretmanager/secretmanager.go 43.92% <0.00%> (-12.84%) :arrow_down:
...are/http/routerchecker/routerchecker_middleware.go 54.54% <0.00%> (-10.84%) :arrow_down:
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Sep 15 '22 21:09 codecov[bot]

More work needed to make certification tests pass.

berndverst avatar Sep 15 '22 22:09 berndverst