components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

add nil/empty test cases for state conformance

Open berndverst opened this issue 3 years ago • 5 comments

Signed-off-by: Bernd Verst [email protected]

Description

Add test cases for nil / empty string state store conformance.

berndverst avatar Aug 22 '22 18:08 berndverst

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@5595de6). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1992   +/-   ##
=========================================
  Coverage          ?   37.67%           
=========================================
  Files             ?      192           
  Lines             ?    23982           
  Branches          ?        0           
=========================================
  Hits              ?     9035           
  Misses            ?    14181           
  Partials          ?      766           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 22 '22 18:08 codecov[bot]

/ok-to-test

berndverst avatar Aug 22 '22 18:08 berndverst

@yaron2 @artursouza

Some components allow empty string in set operations and others do not. Some handle null values, empty bytes etc well and others do not.

Additional conformance test run for Azure components etc: https://github.com/dapr/components-contrib/actions/runs/2906247028

Do we want to standardize how nil / empty values are handled, or do we want to completely disallow them?

berndverst avatar Aug 22 '22 18:08 berndverst

/ok-to-test

berndverst avatar Aug 22 '22 18:08 berndverst

Latest run: https://github.com/dapr/components-contrib/actions/runs/2906323914

berndverst avatar Aug 22 '22 18:08 berndverst

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Sep 22 '22 16:09 dapr-bot

This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Sep 29 '22 16:09 dapr-bot