components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Update code to reflect renaming on UnlockResponse.Status

Open tmacam opened this issue 2 years ago • 1 comments

Description

PR dapr/dapr#4989 (issue dapr/dapr#4988) updated the names of some enums in UnlockResponse.Status ProtoBuff definition:

  • LOCK_UNEXIST became LOCK_DOES_NOT_EXIST
  • LOCK_BELONG_TO_OTHERS became LOCK_BELONGS_TO_OTHERS

Code implementing Distributed Lock component in components-contrib needs to be updated to account for this modification.

This PR accomplishes this by updating contants mapping back to the two enums above to match their new names.

Fixes dapr/components-contrib#1950

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1950

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

tmacam avatar Aug 10 '22 22:08 tmacam

Codecov Report

Merging #1958 (a259f0a) into master (b3e18bb) will increase coverage by 0.03%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1958      +/-   ##
==========================================
+ Coverage   37.62%   37.66%   +0.03%     
==========================================
  Files         192      192              
  Lines       23941    23941              
==========================================
+ Hits         9008     9017       +9     
+ Misses      14169    14159      -10     
- Partials      764      765       +1     
Impacted Files Coverage Δ
lock/redis/standalone.go 52.99% <0.00%> (ø)
state/in-memory/in_memory.go 46.00% <0.00%> (+3.42%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 10 '22 22:08 codecov[bot]