components-contrib
components-contrib copied to clipboard
dapr
Initial creation of workflows building block
Signed-off-by: Ryan Lettieri [email protected]
Description
Initial Creation of the workflows building block using temporal
Note that due to a merge issue and git confusion, there are a very large amount of go.sum and go.mod files in the "tests" directory edited in this PR. Those can be ignored
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Related Proposal: https://github.com/dapr/dapr/issues/4576
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
Adding the do-not-merge label to make sure no maintainer merges this before the 1.9 release.
Codecov Report
Merging #1941 (b3e90c2) into master (a20a2b2) will increase coverage by
0.06%. The diff coverage is0.00%.
@@ Coverage Diff @@
## master #1941 +/- ##
==========================================
+ Coverage 37.92% 37.98% +0.06%
==========================================
Files 193 193
Lines 24566 24584 +18
==========================================
+ Hits 9316 9338 +22
+ Misses 14538 14529 -9
- Partials 712 717 +5
| Impacted Files | Coverage Δ | |
|---|---|---|
| tests/conformance/common.go | 16.90% <0.00%> (-0.91%) |
:arrow_down: |
| configuration/azure/appconfig/appconfig.go | 73.93% <0.00%> (+9.40%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
Conformance: https://github.com/dapr/components-contrib/actions/runs/3055926528 Certification: https://github.com/dapr/components-contrib/actions/runs/3055926532
This PR is being held open until the end of 1.9 in-case there're some hidden broken changes. Furthermore, since the API changes are not pushed into master, this isn't a strong need to have this merged into 1.9 The PR will be updated with the latest changes from master to ensure that it is not out of date. Once the code-freeze for 1.9 is complete, this can be merged into 1.10
Components conformance test
Commit ref: 8d5405fcf9ee7835c8a7ca77f24f7779a77b70cd
✅ All conformance tests passed
All tests have reported a successful status
Components certification test
Commit ref: 8d5405fcf9ee7835c8a7ca77f24f7779a77b70cd
❌ Some certification tests failed
These tests failed:
- bindings.azure.eventhubs
Components certification test
Commit ref: 3a26c43127b1a86fa773cce15e4550dd4fdeadee
✅ All certification tests passed
All tests have reported a successful status
Components conformance test
Commit ref: 3a26c43127b1a86fa773cce15e4550dd4fdeadee
✅ All conformance tests passed
All tests have reported a successful status
I'll merge once @cgillum can do another quick check and give an approval.
I noticed there's a binary in this PR under /.github/infrastructure/conformance/temporal/worker named
worker. Is that supposed to be checked into GitHub?
The worker binary definitely needs to be removed @RyanLettieri. Seems your Docker container builds the binary from the source file anyway.
I was able to verify the workflow locally with:
docker-compose -f ./.github/infrastructure/docker-compose-temporal.yml -p temporal up -d
go test -v -tags=conftests -count=1 ./tests/conformance -run="TestWorkflowsConformance/temporal"
=== RUN TestWorkflowsConformance
=== RUN TestWorkflowsConformance/temporal
=== RUN TestWorkflowsConformance/temporal/init
time="2022-10-27T12:34:28.51554-07:00" level=debug msg="Temporal init start" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
2022/10/27 12:34:28 INFO No logger configured for temporal client. Created default one.
=== RUN TestWorkflowsConformance/temporal/start
time="2022-10-27T12:34:28.526645-07:00" level=info msg="Start test running..." instance=Bernds-MacBook-Pro.local scope=workflowsTest type=log ver=unknown
time="2022-10-27T12:34:28.526677-07:00" level=debug msg="starting workflow" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
time="2022-10-27T12:34:28.540806-07:00" level=debug msg="getting workflow data" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
time="2022-10-27T12:34:33.546585-07:00" level=debug msg="getting workflow data" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
time="2022-10-27T12:34:33.55706-07:00" level=debug msg="terminating workflow" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
time="2022-10-27T12:34:33.576683-07:00" level=debug msg="getting workflow data" instance=Bernds-MacBook-Pro.local scope=testLogger type=log ver=unknown
time="2022-10-27T12:34:33.585117-07:00" level=info msg="Start test done." instance=Bernds-MacBook-Pro.local scope=workflowsTest type=log ver=unknown
--- PASS: TestWorkflowsConformance (5.07s)
--- PASS: TestWorkflowsConformance/temporal (5.07s)
--- PASS: TestWorkflowsConformance/temporal/init (0.01s)
--- PASS: TestWorkflowsConformance/temporal/start (5.06s)
PASS
ok github.com/dapr/components-contrib/tests/conformance 5.112s
@RyanLettieri please open a Docs issue to create the new Workfows section in the Docs, and then list the temporal component as Alpha (due to the fact the building block is Alpha)
@RyanLettieri please open a Docs issue to create the new Workfows section in the Docs, and then list the temporal component as Alpha (due to the fact the building block is Alpha)
@berndverst would this previously created issue suffice: https://github.com/dapr/docs/issues/2798 ?