components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Allow metadata to flow through service bus queue

Open halspang opened this issue 3 years ago • 1 comments

Description

This commit lets metadata bind to a message and be read when the message is received. This allows for the distributed tracing of events.

This is required for https://github.com/dapr/dapr/issues/4884.

Other binding/pubsubs will need to be examined but this was chosen as the first attempt. Once the dapr changes are committed, we can go through the other input bindings.

Signed-off-by: Hal Spang [email protected]

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

This PR starts to address https://github.com/dapr/dapr/issues/4884 but requires changes in dapr/dapr after.

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

halspang avatar Jul 25 '22 19:07 halspang

Codecov Report

Merging #1911 (eb64cce) into master (38fc439) will increase coverage by 0.02%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1911      +/-   ##
==========================================
+ Coverage   37.62%   37.64%   +0.02%     
==========================================
  Files         192      192              
  Lines       23941    23951      +10     
==========================================
+ Hits         9008     9017       +9     
  Misses      14169    14169              
- Partials      764      765       +1     
Impacted Files Coverage Δ
...indings/azure/servicebusqueues/servicebusqueues.go 2.43% <0.00%> (-0.13%) :arrow_down:
state/in-memory/in_memory.go 46.00% <0.00%> (+3.42%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 05 '22 19:08 codecov[bot]

Approved this! But — do you think this could be implemented in the pubsub too, unless it’s not needed there?

(I’m hoping we can soon unify the two implementations too, and the closer they are already, the better)

ItalyPaleAle avatar Aug 12 '22 00:08 ItalyPaleAle

Approved this! But — do you think this could be implemented in the pubsub too, unless it’s not needed there?

(I’m hoping we can soon unify the two implementations too, and the closer they are already, the better)

Yeah I can take a quick look at it and see if it's a small change. If it's bigger, I'll open it as a separate PR.

halspang avatar Aug 12 '22 21:08 halspang

/ok-to-test

halspang avatar Aug 12 '22 21:08 halspang

@halspang (FYI @ItalyPaleAle ) please open a separate PR for service bus pubsub if this needs to be implemented there also.

berndverst avatar Aug 16 '22 00:08 berndverst