components-contrib
components-contrib copied to clipboard
dapr
Local keyring secret store
Description
Implement keyring secret store
Issue reference
Please reference the issue this PR will close: #1037
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]
@helbing thanks for your contributions!
/cc @artursouza please review as well.
@helbing thanks for the contribution :)
As mentioned in the comment there, we cannot currently accept dependencies that use CGO in Dapr.
We are currently working on a new way to import components so they're out-of-process, and that would allow using CGO as well. You can track the progress here: https://github.com/dapr/dapr/issues/3787
Other proposed components are pending on that, for example SQLite: https://github.com/dapr/components-contrib/pull/1654
@helbing @ItalyPaleAle I covert it as draft until gRPC components are available.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@helbing take a look at https://github.com/dapr-sandbox/components-go-sdk https://docs.dapr.io/developing-applications/develop-components/pluggable-components/
I am going to close this PR since it cannot be merged in this repository due to the CGo requirement.
Even with external (pluggable) secret store components, we wouldn't be able to accept this in-tree, as pluggable components are released separately.
Thanks for the contribution and sorry we cannot accept it at this time!