components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

RocketMQ fix metadata properties

Open helbing opened this issue 3 years ago • 3 comments

Signed-off-by: helbing [email protected]

Description

fix RocketMQ pubsub metadata properties

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1772

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [ ] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number]

helbing avatar Jun 28 '22 11:06 helbing

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Aug 04 '22 22:08 dapr-bot

@helbing please look at failing checks

addjuarez avatar Aug 09 '22 16:08 addjuarez

ping @helbing

yaron2 avatar Aug 15 '22 22:08 yaron2

ping @helbing

yaron2 avatar Aug 19 '22 21:08 yaron2

Codecov Report

Merging #1817 (e7b5cf8) into master (3fabf17) will decrease coverage by 0.06%. The diff coverage is 20.00%.

@@            Coverage Diff             @@
##           master    #1817      +/-   ##
==========================================
- Coverage   37.96%   37.90%   -0.07%     
==========================================
  Files         192      192              
  Lines       24122    24137      +15     
==========================================
- Hits         9158     9149       -9     
- Misses      14194    14216      +22     
- Partials      770      772       +2     
Impacted Files Coverage Δ
pubsub/rocketmq/rocketmq.go 28.62% <11.11%> (-0.79%) :arrow_down:
pubsub/rocketmq/metadata.go 61.11% <27.27%> (-17.47%) :arrow_down:
state/in-memory/in_memory.go 42.58% <0.00%> (-3.43%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 22 '22 20:08 codecov[bot]