components-contrib
components-contrib copied to clipboard
SQS binding missing endpoint option (and others) from the pubsub integration
In what area(s)?
/area runtime
What version of Dapr?
1.6.0
Expected Behavior
When testing dapr integrations locally with a localstack image to simulate AWS, the sqs/sns pub sub binding allowed for a custom endpoint to be provided: AWS SNS/SQS. The sqs binding however is missing this option, preventing the use of the localstack image for testing: AWS SQS. This also applies to any of the sqs specific values in the pubsub specific spec that don't exist in the SQS binding.
apiVersion: dapr.io/v1alpha1
kind: Component
metadata:
name: <NAME>
namespace: <NAMESPACE>
spec:
type: bindings.aws.sqs
version: v1
metadata:
- name: queueName
value: items
- name: region
value: us-west-2
- name: accessKey
value: *****************
- name: secretKey
value: *****************
- name: sessionToken
value: *****************
# - name: endpoint # Optional. <-- missing
# value: "http://localhost:4566"
...
I checked for endpoint
option support for SQS binding, as it seemed to be supported due to https://github.com/dapr/components-contrib/blob/24be879a40e7ef2742beb67f5c1f052b1b5eeae7/bindings/aws/sqs/sqs.go#L152 and I was able to write messages to localstack queue.
Other options may be required for supporting other features - will try to add relevant ones to SQS binding.
Assigning it to myself, please feel free to pitch in if anyone else has been already working.
/assign
@DeepanshuA are you working on this?
@robertojrojas maybe this is something you can investigate in the future?