components-contrib icon indicating copy to clipboard operation
components-contrib copied to clipboard

Support Azure Service Bus metadata handling in bindings component

Open CodeMonkeyLeet opened this issue 3 years ago • 5 comments

Describe the feature

Per the implementation of #1071 it looks like the Azure Service Bus (ASB) queues bindings component should also be improved to support all ASB message properties. From the code it looks like only MessageID and CorrelationID are explicitly handled on Invoke, and Label is additionally handled on Read.

Release Note

RELEASE NOTE: ADD Comprehensive Azure Service Bus message handling to Azure Service Bus Queues bindings.

CodeMonkeyLeet avatar Oct 07 '21 22:10 CodeMonkeyLeet

/assign

mukundansundar avatar Nov 11 '21 04:11 mukundansundar

FYI @artursouza

berndverst avatar Jul 07 '22 17:07 berndverst

@ItalyPaleAle to verify. The share code of all ASB components probably already extracts and sets all ASB properties in Binding Invoke - but if it doesn't that can probably added easily.

berndverst avatar Feb 01 '23 22:02 berndverst

It doesn't look like it's happening to the binding: https://github.com/dapr/components-contrib/blob/e4fed1324f7e527d404c9189aa3ad6ffd5452406/bindings/azure/servicebusqueues/servicebusqueues.go#L176

I don't remember why it was done this way, probably to preserve the past behavior. But yes, it shouldn't be hard to add this with the shared code...

ItalyPaleAle avatar Feb 02 '23 05:02 ItalyPaleAle

Needs to validate if this is still not done given the rewrites of the component. /cc @ItalyPaleAle

artursouza avatar Jun 30 '23 17:06 artursouza