components-contrib
components-contrib copied to clipboard
Support Azure Service Bus metadata handling in bindings component
Describe the feature
Per the implementation of #1071 it looks like the Azure Service Bus (ASB) queues bindings component should also be improved to support all ASB message properties. From the code it looks like only MessageID and CorrelationID are explicitly handled on Invoke, and Label is additionally handled on Read.
Release Note
RELEASE NOTE: ADD Comprehensive Azure Service Bus message handling to Azure Service Bus Queues bindings.
/assign
FYI @artursouza
@ItalyPaleAle to verify. The share code of all ASB components probably already extracts and sets all ASB properties in Binding Invoke - but if it doesn't that can probably added easily.
It doesn't look like it's happening to the binding: https://github.com/dapr/components-contrib/blob/e4fed1324f7e527d404c9189aa3ad6ffd5452406/bindings/azure/servicebusqueues/servicebusqueues.go#L176
I don't remember why it was done this way, probably to preserve the past behavior. But yes, it shouldn't be hard to add this with the shared code...
Needs to validate if this is still not done given the rewrites of the component. /cc @ItalyPaleAle