cli
cli copied to clipboard
feature/podman: Updating dapr cli to allow different container runtime
Description
Adding a new argument --container-runtime to be passed during dapr init and dapr uninstall commands.
This allows a user to provide a container runtime environment such as podman where in some instances docker is unavailable.
This would be used to stand up a repeatable Dapr environment with the placement, zipkin and redis containers in the desired container runtime environment.
The default container runtime is docker, therefore the behavior is unaltered unless we provide podman as the runtime.
Example:
# Install Dapr using podman as container runtime
$ dapr init --container-runtime podman
# Uninstall Dapr using podman as container runtime
$ dapr uninstall --cotnainer-runtime podman
Issue reference
closes #257
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [ ] Created/updated tests
- [x] Extended the documentation
Thanks for this PR! Notice that build/tests are failing.
Thanks for this PR! Notice that build/tests are failing.
@yaron2 Thanks, I didn't assume that this may break the e2e tests, I'll have a look at them when I have a chance.
@yaron2
Standalone e2e tests are passing in the dev-container:

The lint issues fixed too for the build action:

@martin-bucinskas Thanks for this PR ... we will review it soon ...
@martin-bucinskas Could you fix the conflicts in the PR ? Thanks ...
@martin-bucinskas Please comment /assign on #257 to assign the issue to yourself.
I am also thinking should the direct commands that are run from standalone.go uninstall.go etc be abstracted away with an interface, struct and receiver functions?
Thereby each implementation can have its own code and only the interface is used for calling? This would also make the code potentially more testable ...
cc @yaron2 @artursouza thoughts on this?
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@martin-bucinskas Can you update the PR to resolve conflicts and address comments?
@martin-bucinskas Can you update the PR to resolve conflicts and address comments?
@martin-bucinskas @mukundansundar I am planning to take this forward by resolving the conflicts and review comments. I will take the commits and create a new PR. @martin-bucinskas Let me know if you still planning on completing this.
@martin-bucinskas @mukundansundar I am planning to take this forward by resolving the conflicts and review comments. I will take the commits and create a new PR. @martin-bucinskas Let me know if you still planning on completing this.
More than happy to, I've been quite busy lately and haven't been able to get back into this. It would be much appreciated!
@martin-bucinskas thanks for the PR. This work has been included in #1041