cli
cli copied to clipboard
Feat/dashboard supports random port
Description
- support
dashboardLocalPort
set to0
- update
pf.LocalPort
whenPortForward
isReady
Issue reference
Please reference the issue this PR will close: #863
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [x] Created/updated tests
- [ ] Extended the documentation
@imneov Please fix linter errors ...
Codecov Report
Merging #874 (8df3aec) into master (9e07fcd) will decrease coverage by
0.07%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## master #874 +/- ##
==========================================
- Coverage 29.20% 29.13% -0.08%
==========================================
Files 35 35
Lines 2359 2365 +6
==========================================
Hits 689 689
- Misses 1594 1600 +6
Partials 76 76
Impacted Files | Coverage Δ | |
---|---|---|
pkg/kubernetes/portforward.go | 0.00% <0.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@mukundansundar Thanks for the suggestions.
@imneov Please do fix the DCO and the conflicts ...
@imneov Please do fix the DCO and the conflicts ...
OK, It`s done.
@imneov Almost done ... just a few small changes and linter fixes ...
@mukundansundar Thank you kindly! I fix it.
@imneov Almost done ... just a few small changes and linter fixes ...
@mukundansundar Thank you kindly! I fix it.
@imneov Let me know if you will be able to address some of the requested changes ... Thanks
@imneov Almost done ... just a few small changes and linter fixes ...
@mukundansundar Thank you kindly! I fix it.
@imneov Let me know if you will be able to address some of the requested changes ... Thanks
HI,@mukundansundar ~ I have responded to the modification in the commit below, what else should I do?
- https://github.com/dapr/cli/pull/874/commits/96f1224ffb8e6c469a59540867eb941659ea7fd3
- https://github.com/dapr/cli/pull/874/commits/67a8ea7f79b8d7a1d6f69e91b245fbbc249fc58b
LGTM However, There will be a need to update the documentation here - https://docs.dapr.io/reference/cli/dapr-dashboard/ . @imneov Would you be able to create a doc issue here - https://github.com/dapr/docs/issues and a small PR to update the same.
Please address the comments.
It's fixed
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@imneov Please update the branch and resolve the conflicts. Additionally, Please update the documentation also.
@imneov Please update the branch and resolve the conflicts. Additionally, Please update the documentation also.
@pravinpushkar It's done.
@pravinpushkar HI~ Is there anything else I need to do?
@pravinpushkar HI~ Is there anything else I need to do?
There are few PR checks failing, could you please have a look? For now I have re-triggered some of them. Hopefully E2E- Upgrade path tests should pass as it looked temporary failure. But other one should not have failed.
@pravinpushkar HI~ Is there anything else I need to do?
There are few PR checks failing, could you please have a look? For now I have re-triggered some of them. Hopefully E2E- Upgrade path tests should pass as it looked temporary failure. But other one should not have failed.
HI, @pravinpushkar ~ I don't find the failing PR checks,could you give me a link?