cli
cli copied to clipboard
add dashboard flag utils tests and adjust some code
Description
Adding integration test for dashboard '--address' flag and adjust some code
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
Codecov Report
Merging #782 (38ea62f) into master (9c8de2c) will decrease coverage by
1.05%
. The diff coverage is21.42%
.
@@ Coverage Diff @@
## master #782 +/- ##
==========================================
- Coverage 29.39% 28.34% -1.06%
==========================================
Files 35 36 +1
Lines 2327 2505 +178
==========================================
+ Hits 684 710 +26
- Misses 1570 1720 +150
- Partials 73 75 +2
Impacted Files | Coverage Δ | |
---|---|---|
utils/utils.go | 14.60% <21.42%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us.
@artursouza CC
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@marviniter Can you resolve the conflicts?
@artursouza Can you review this PR?
@marviniter can you resolve the PR conflicts?
@marviniter can you resolve the PR conflicts?
ok,i will solve it later.
@marviniter Can you resolve the PR conflicts ?
for now closing this PR. Please open a new PR for this fix.