cli
cli copied to clipboard
Add ProxyFromEnvironment in downloadFile method (#1048)
Codecov Report
Merging #1049 (1674c98) into release-1.8 (6ccc907) will decrease coverage by
0.01%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## release-1.8 #1049 +/- ##
===============================================
- Coverage 29.25% 29.24% -0.02%
===============================================
Files 35 35
Lines 2338 2339 +1
===============================================
Hits 684 684
- Misses 1579 1580 +1
Partials 75 75
Impacted Files | Coverage Δ | |
---|---|---|
pkg/standalone/standalone.go | 4.58% <0.00%> (-0.01%) |
:arrow_down: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
@mukundansundar is this PR ready to be merged?
This fix got released with 1.9. Should we still release this with 1.8? @mukundansundar @yaron2
Had a discussion with @yaron2 and yes... for now this is not needed ...