cli icon indicating copy to clipboard operation
cli copied to clipboard

Add ProxyFromEnvironment in downloadFile method (#1048)

Open Lichmaker opened this issue 2 years ago • 3 comments

Add ProxyFromEnvironment in downloadFile method.

This is a additional PR to #1048

Lichmaker avatar Aug 17 '22 06:08 Lichmaker

Codecov Report

Merging #1049 (1674c98) into release-1.8 (6ccc907) will decrease coverage by 0.01%. The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           release-1.8    #1049      +/-   ##
===============================================
- Coverage        29.25%   29.24%   -0.02%     
===============================================
  Files               35       35              
  Lines             2338     2339       +1     
===============================================
  Hits               684      684              
- Misses            1579     1580       +1     
  Partials            75       75              
Impacted Files Coverage Δ
pkg/standalone/standalone.go 4.58% <0.00%> (-0.01%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 17 '22 06:08 codecov[bot]

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

dapr-bot avatar Sep 24 '22 07:09 dapr-bot

@mukundansundar is this PR ready to be merged?

shubham1172 avatar Sep 24 '22 14:09 shubham1172

This fix got released with 1.9. Should we still release this with 1.8? @mukundansundar @yaron2

pravinpushkar avatar Oct 19 '22 05:10 pravinpushkar

Had a discussion with @yaron2 and yes... for now this is not needed ...

mukundansundar avatar Oct 19 '22 06:10 mukundansundar