cli icon indicating copy to clipboard operation
cli copied to clipboard

Add ProxyFromEnvironment in downloadFile method

Open Lichmaker opened this issue 2 years ago β€’ 1 comments

Description

Add ProxyFromEnvironment in downloadFile method.

Issue reference

Please reference the issue this PR will close: #1043

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • [x] Code compiles correctly
  • [ ] Created/updated tests
  • [ ] Extended the documentation

Lichmaker avatar Aug 16 '22 06:08 Lichmaker

@Lichmaker Could you please check the lint failures.

pravinpushkar avatar Aug 16 '22 15:08 pravinpushkar

Codecov Report

Merging #1048 (4b488b9) into master (5a28708) will decrease coverage by 0.11%. The diff coverage is 9.52%.

@@            Coverage Diff             @@
##           master    #1048      +/-   ##
==========================================
- Coverage   29.24%   29.13%   -0.12%     
==========================================
  Files          35       35              
  Lines        2342     2358      +16     
==========================================
+ Hits          685      687       +2     
- Misses       1582     1595      +13     
- Partials       75       76       +1     
Impacted Files Coverage Ξ”
pkg/kubernetes/kubernetes.go 0.00% <0.00%> (ΓΈ)
pkg/standalone/standalone.go 4.49% <0.00%> (-0.06%) :arrow_down:
pkg/kubernetes/upgrade.go 20.22% <50.00%> (+1.40%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar Aug 17 '22 04:08 codecov[bot]

@pravinpushkar Glad to do it. Please check it. πŸ˜ƒ https://github.com/dapr/cli/pull/1049

Lichmaker avatar Aug 17 '22 06:08 Lichmaker

@Lichmaker Can you please create a docs PR on how to use this ? Potentially add it in this page? https://docs.dapr.io/operations/troubleshooting/common_issues/ cc @greenie-msft WDYT?

mukundansundar avatar Aug 18 '22 20:08 mukundansundar

@Lichmaker Can you please create a docs PR on how to use this ? Potentially add it in this page? https://docs.dapr.io/operations/troubleshooting/common_issues/ cc @greenie-msft WDYT?

OK πŸ˜ƒ I'll try

Lichmaker avatar Aug 22 '22 00:08 Lichmaker

@Lichmaker Thanks for the change to include docs PR !!

mukundansundar avatar Aug 25 '22 08:08 mukundansundar