cli
cli copied to clipboard
Add ProxyFromEnvironment in downloadFile method
Description
Add ProxyFromEnvironment in downloadFile method.
Issue reference
Please reference the issue this PR will close: #1043
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [x] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
@Lichmaker Could you please check the lint failures.
Codecov Report
Merging #1048 (4b488b9) into master (5a28708) will decrease coverage by
0.11%
. The diff coverage is9.52%
.
@@ Coverage Diff @@
## master #1048 +/- ##
==========================================
- Coverage 29.24% 29.13% -0.12%
==========================================
Files 35 35
Lines 2342 2358 +16
==========================================
+ Hits 685 687 +2
- Misses 1582 1595 +13
- Partials 75 76 +1
Impacted Files | Coverage Ξ | |
---|---|---|
pkg/kubernetes/kubernetes.go | 0.00% <0.00%> (ΓΈ) |
|
pkg/standalone/standalone.go | 4.49% <0.00%> (-0.06%) |
:arrow_down: |
pkg/kubernetes/upgrade.go | 20.22% <50.00%> (+1.40%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
@pravinpushkar Glad to do it. Please check it. π https://github.com/dapr/cli/pull/1049
@Lichmaker Can you please create a docs PR on how to use this ? Potentially add it in this page? https://docs.dapr.io/operations/troubleshooting/common_issues/ cc @greenie-msft WDYT?
@Lichmaker Can you please create a docs PR on how to use this ? Potentially add it in this page? https://docs.dapr.io/operations/troubleshooting/common_issues/ cc @greenie-msft WDYT?
OK π I'll try
@Lichmaker Thanks for the change to include docs PR !!