cli
cli copied to clipboard
Added `--daprd-flags` option to `dapr run`
Description
Adds a --daprd-flags
option to dapr run
to allow passing arbitrary flags to daprd.
Issue reference
Fixes #1038
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [X] Code compiles correctly
- [X] Created/updated tests
- [ ] Extended the documentation
- This is an advanced option and can be learnt about from
dapr run --help
. I don't know if this needs to be put in the docs in addition to that
- This is an advanced option and can be learnt about from
Codecov Report
Merging #1039 (8ef909c) into master (d229506) will increase coverage by
0.13%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #1039 +/- ##
==========================================
+ Coverage 29.34% 29.47% +0.13%
==========================================
Files 35 35
Lines 2334 2344 +10
==========================================
+ Hits 685 691 +6
- Misses 1574 1576 +2
- Partials 75 77 +2
Impacted Files | Coverage Δ | |
---|---|---|
pkg/standalone/run.go | 59.55% <66.66%> (+0.02%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
If it is only for dev/test purpose(not recommended to be used by users) then can we have something like --daprd-dev-flags
or something like that . I think it will provide clarity whether user should prefer direct flags or this one.
@ItalyPaleAle @mukundansundar @yaron2
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Bumping this up. @mukundansundar @yaron2 WDYT about this PR?
One thing that I learnt more recently than this PR is that we could mark the flag as "hidden", so it will still available but it won't appear in the list when people do dapr --help
. It's a sort of "IYKYK" 😃
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!
Still pretty much relevant to me
closing this PR for now. Can be handled as part of running multiple dapr apps feature if needed.