cli
cli copied to clipboard
dapr
Adding mariner support in dapr init
Signed-off-by: shivam [email protected]
Description
It adds support for mariner images in dapr init
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1004
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
- [ ] Code compiles correctly
- [ ] Created/updated tests
- [ ] Extended the documentation
@shivamkm07 Can we add an E2E test for upgrade secanrio using mariner?
Codecov Report
Merging #1029 (8d1faac) into master (5a28708) will decrease coverage by
0.10%. The diff coverage is10.00%.
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
- Coverage 29.24% 29.14% -0.11%
==========================================
Files 35 35
Lines 2342 2357 +15
==========================================
+ Hits 685 687 +2
- Misses 1582 1594 +12
- Partials 75 76 +1
| Impacted Files | Coverage Δ | |
|---|---|---|
| pkg/kubernetes/kubernetes.go | 0.00% <0.00%> (ø) |
|
| pkg/standalone/standalone.go | 4.50% <0.00%> (-0.05%) |
:arrow_down: |
| pkg/kubernetes/upgrade.go | 20.22% <50.00%> (+1.40%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}
@shivamkm07 IMO we should add E2E tests for at least init and uninstall in k8s mode. WDYT ?
@shivamkm07 IMO we should add E2E tests for at least init and uninstall in k8s mode. WDYT ?
Done
Created docs issue https://github.com/dapr/docs/issues/2747 @shivamkm07
Docs PRs: https://github.com/dapr/docs/pull/2752 https://github.com/dapr/cli/pull/1054