ds-token

ds-token copied to clipboard

erc20 interface been broken

1

symbol & name of the token should be defined as a string, but you defined as byte32, which breaks the erc20 interface. so when I use the standard erc20 interface...

huahuayu

Hi, The function `DSToken.transferFrom` emits an event `Transfer`, which is not documented in the README doc. https://github.com/dapphub/ds-token/blob/16f187acc15dd839589be60173ad1ebd0716eb82/src/token.sol#L80 A potential fix could be adding "Emits a `Transfer` event" to the README...

DocCon-team

Broken link on repo

2

The website link on this repo (https://github.com/dapphub/ds-token) is broken. We link out to this page from the [ethereum.org developer docs](https://ethereum.org/en/developers/docs/smart-contracts/libraries/#standards). Could you confirm the status of this project?

minimalsm

compatibility with solc 0.6.6

1

mesozoic-technology

Intentional use of accounting terms?

2

I'm wondering if the use of the words 'debit' and 'credit' in the definitions of 'mint' and 'burn' are intentionally used in the technical accounting sense of the term or...

charles-cooper

* replace usages of uint(-1) with type(uint).max * loosen pragma * for more info, see https://docs.soliditylang.org/en/breaking/080-breaking-changes.html#new-restrictions

mmsqe