dapptools icon indicating copy to clipboard operation
dapptools copied to clipboard

Bump nixpkgs and hevm dependencies

Open arcz opened this issue 3 years ago • 6 comments

Description

hevm is currently broken in nixpkgs because text-format doesn't support the new GHC that was bumped in this PR (https://github.com/NixOS/nixpkgs/pull/160733). Fortunately, hevm appears to not use text-format so it can be removed from dependencies. To make hevm compatible with the upcoming 22.05 release of nixpkgs, I bumped nixpkgs to the latest unstable (it will branch off to become 22.05 soon https://github.com/NixOS/nixpkgs/issues/165792) and updated the code to work with the newer version of GHC and dependencies (aeson in particular).

Checklist

  • [x] tested locally
  • [ ] added automated tests
  • [ ] updated the docs
  • [ ] updated the changelog

arcz avatar Apr 19 '22 17:04 arcz

Thanks! Looks like ci is failing when trying to build cln. Not sure what's going on there...

Does this also bump us to a newer ghc version with support for arm macs (fine if not, just asking to understand).

d-xo avatar Apr 20 '22 09:04 d-xo

This should enable M1 support if it was not working already. We are building M1 releases in Echidna which obviously uses hevm and everything works. I hope fix the build over the weekend.

arcz avatar Apr 22 '22 10:04 arcz

great news :)

d-xo avatar Apr 22 '22 23:04 d-xo

I'm still on it, I'm struggling to get the CI tests working after all the updates

arcz avatar May 09 '22 14:05 arcz

@arcz sorry I should have commented here. I've been playing around with this a bit since the ghc compiler version update is a blocker for me atm.

So far I've managed to fix the cln build issue and get the shared hevm build working, but I'm still stuck on the static build. My current progress is here: https://github.com/dapphub/dapptools/compare/bump-nixpkgs.

d-xo avatar May 10 '22 15:05 d-xo

@d-xo I merged your branch and fixed the build but I don't know why this test fails:

	Running test_4byte ... FAILURE
 expected [transfer(address,uint256)] but was []

It first failed on my local build but then it worked fine. Not sure what's going on there. The static build is indeed broken and I'm not sure how to fix it.

arcz avatar Jul 27 '22 15:07 arcz