Added back Yul tests that were fixed by Solidity

[hrkrshnn]

Description

Solidity fixes all the issues found: https://github.com/ethereum/solidity/issues/9500

Did not test it locally :( Hopefully the CI can do it?

Checklist

• [ ] tested locally
• [ ] added automated tests
• [ ] updated the docs
• [ ] updated the changelog

[hrkrshnn]

Also how can I test this locally?

[hrkrshnn]

The tests are failing, but they are not matching with the tests from the solidity repo:

executing test: varNameCleaner/function_names.yul with z3
Could not compile second Yul source. (/build/tmp.05kOOioBc4)
{
calldatacopy(0,0,1024)
    let f_1
    function f()
    { let f_1 }
    let f_2
}

The test was updated in 0.7.1: https://github.com/ethereum/solidity/blob/develop/test/libyul/yulOptimizerTests/varNameCleaner/function_names.yul

Any chance that it's pulling from the old repo?

[d-xo]

Any chance that it's pulling from the old repo?

yeah we're still using 0.6.7 for the tests: https://github.com/dapphub/dapptools/blob/c3c761dc01d44389db67291f40561a71d2baff2b/nix/hevm-tests/default.nix#L7, if you're feeling motivated you can bump that to 0.8.7 and then there will presumably be some work needed to categorise any new tests that might be failing.

Also how can I test this locally?

nix-build -A hevm-tests from the repo root.