dapptools
dapptools copied to clipboard
Remove .sethrc
Sethrc is dangerous and confusing because it always overrides local env vars
people should just put global config in their .zshrc/etc instead so they can still override env vars locally
IMO we should remove, or at least not encourage it in the readme 😅
Good example of how this behavior can even confuse experts: https://github.com/makerdao/spells-mainnet/pull/192
I would be totally down to remove all global config files. I would probably keep the project local .dapprc / .sethrc for now?
Can agree with removing all global configs.
But at that point don't you think local .dapprc and .sethrc serve mostly the same purpose? Could just remove .sethrc (and source .dapprc before seth commands as well) and tell ppl to use a .dapprc if they want to configure seth env vars locally for a project. I don't think the name is super counterintuitive either because could stand for "dapptools run commands" :p
I'm wondering if there are maybe situations when you might want to set different values for the same variable when invoking seth or dapp?
ppl can still do that if they check $0 in their .dapprc doe right?
did not know about $0 until now. TIL :)