dapple icon indicating copy to clipboard operation
dapple copied to clipboard

refactor dapple install

Open mhhf opened this issue 9 years ago • 5 comments

refactor install and dependencies: work with pure functions and clear cli type install args. dapphub as default

dapple install dappsys # install from dapphub
dapple install ipfs://asdasdas --ipfs
dapple install git://adasdasd --git

mhhf avatar Mar 21 '16 15:03 mhhf

When I think about this, we should probably deprecate it all together and make installing from dapphub the only option when installing from cli. @ryepdx @nmushegian Thoughts?

mhhf avatar Apr 01 '16 12:04 mhhf

I'd like to support referring to packages by ipfs hash.

nmushegian avatar Apr 01 '16 20:04 nmushegian

I feel like I can see both sides to this one, since removing the extra sources could simplify the codebase and since one could argue including additional installation sources might be an example of YAGNI. On the other hand, that sort of functionality is available in package managers such as NPM and Pip, so developers are probably going to approach Dapple with the expectation that it too will support installing from git repositories, HTTP servers, IPFS, etc. I'm inclined to follow the herd on this one because of that, but I'd also be interested in hearing counterarguments.

ryepdx avatar Apr 02 '16 20:04 ryepdx

Isn't "Install from IPFS hash" simply one of two steps in "Install from Dapphub" (the first step being "Download IPFS hash from Dapphub")?

dbrock avatar Apr 02 '16 20:04 dbrock

Yeah, it is. Enabling installation from IPFS hash would basically just be a matter of changing the place from where the hash is pulled.

ryepdx avatar Apr 02 '16 20:04 ryepdx