nba-smart-contracts
nba-smart-contracts copied to clipboard
Refactor mintMoment to use subedition
Instructions
Refactor the existing minting method to be subedition aware, and remove the variant method added with the subedition feature branch.
Issue To Be Solved
Having a redundant minting method is confusing, and leaves a foot gun around in case one first mints moments with subeditions.
(Optional): Suggest A Solution
Steps to required deprecate/delete:
- Have NBA-API universally use the subedition minting method
- Refactor the initial minting method to be identical to the subedition minting method
- Have NBA-API universally use the initial minting method (that is now subedition aware)
- Remove the subedition minting method.
(Optional): Context
Flagged by @dete when reviewing the subedition change, and wanted to make sure it did not fall off the board.