nba-smart-contracts icon indicating copy to clipboard operation
nba-smart-contracts copied to clipboard

Published 20 hours ago • verified publisher icon dapperlabs

Add remix

Open anatoly256 opened this issue 2 years ago • 2 comments

anatoly256 avatar Sep 20 '22 16:09 anatoly256

What is remix? And based off of the conversation we had with Dete about how we want to do composable features in the future, I would potentially think about doing upgrades with new contracts instead of adding a feature with a change to the existing contract

joshuahannan avatar Sep 20 '22 17:09 joshuahannan

A remix is similar in intent to traditional sports trading card parallels. Specifically, we are interested in minting new Top Shot NFTs that have a subedition with their own serial number range, while still incrementing the total edition count. The subedition will be used to indicate alternate media should be used for the moment. It's intended that the changes we're making should not break any existing use of the Top Shot contract - no community contracts depending on our contract should need to change as a result. We will also need a way to map a moment to its sub edition (not yet part of this PR). That mapping will likely need to live in a separate contract. Going to start an issue to continue discussion of the feature.

jrkhan avatar Sep 22 '22 16:09 jrkhan

@anatoly256 @jrkhan is this ready for a review again?

joshuahannan avatar Oct 14 '22 15:10 joshuahannan

@anatoly256 @jrkhan is this ready for a review again?

Should be ready to review.

jrkhan avatar Oct 14 '22 15:10 jrkhan