infra icon indicating copy to clipboard operation
infra copied to clipboard

Generalized the Voting Machine callback interface

Open ben-kaufman opened this issue 7 years ago • 2 comments

Generalized the Voting Machine callback interface to match both reputation and other voting.

Removed unnecessary voteWithSpecifiedAmounts() token parameter.

Seperated Voting Machine Callback Interface from Genesis Protocol Callback Interface.

Fixed bug in the AbsoluteVote internalVote function VoteProposal event.

ben-kaufman avatar Oct 17 '18 13:10 ben-kaufman

  • Please explain the use case for "other voting" .
  • What is the bug at the "AbsoluteVote internalVote function VoteProposal event" ?

orenyodfat avatar Oct 17 '18 20:10 orenyodfat

  1. Using anything which has balances (reputation, tokens, etc.), just making Infra more generalized.
  2. The event was emitting reputation variable which was the user's total reputation instead of rep which is the reputation amount the user actually voted with.

ben-kaufman avatar Oct 18 '18 09:10 ben-kaufman