arc
arc copied to clipboard
bootstrapping endtime-related requirements are off by a second
This line:
https://github.com/daostack/arc/blob/c0baf5921a1d68d377b272ebc54781de3addb66f/contracts/schemes/Auction4Reputation.sol#L146
Should be:
require(now >= auctionsEndTime, "now >= auctionsEndTime");
Because auctionsEndTime is exclusive of the auction period.
This line:
https://github.com/daostack/arc/blob/c0baf5921a1d68d377b272ebc54781de3addb66f/contracts/schemes/Locking4Reputation.sol#L152
Should be:
require(_redeemEnableTime > _lockingEndTime, "redeemEnableTime > lockingEndTime");
Because lockingEndTime is inclusive of the locking period.
@orenyodfat Any status on this?