arc icon indicating copy to clipboard operation
arc copied to clipboard

bootstrapping endtime-related requirements are off by a second

Open dkent600 opened this issue 6 years ago • 1 comments

This line:
https://github.com/daostack/arc/blob/c0baf5921a1d68d377b272ebc54781de3addb66f/contracts/schemes/Auction4Reputation.sol#L146

Should be:

require(now >= auctionsEndTime, "now >= auctionsEndTime");

Because auctionsEndTime is exclusive of the auction period.

This line:

https://github.com/daostack/arc/blob/c0baf5921a1d68d377b272ebc54781de3addb66f/contracts/schemes/Locking4Reputation.sol#L152

Should be:

require(_redeemEnableTime > _lockingEndTime, "redeemEnableTime > lockingEndTime");

Because lockingEndTime is inclusive of the locking period.

dkent600 avatar Mar 29 '19 12:03 dkent600

@orenyodfat Any status on this?

dkent600 avatar Apr 12 '19 10:04 dkent600