arc icon indicating copy to clipboard operation
arc copied to clipboard

a few miscellaneous items on ExternalLocking4Reputation and Auction4Reputation

Open dkent600 opened this issue 7 years ago • 1 comments

  1. This in ExternalLocking4Reputation.initialize is redundant with what already exists in Locking4Reputation._initialize:
require(_lockingEndTime > _lockingStartTime,"_lockingEndTime should be greater than _lockingStartTime");
  1. consider indexing the following event arguments:
  • FixedReputationAllocation.BeneficiaryAddressAdded._beneficiary
  • Auction4Reputation.Bid._bidder
  1. FixedReputationAllocation.enabled will crash when numberOfBeneficiaries is zero:
beneficiaryReward = uint256(int216(reputationReward).div(int256(numberOfBeneficiaries)).fromReal());

Should we do a require with a message?

dkent600 avatar Sep 27 '18 20:09 dkent600

@orenyodfat

dkent600 avatar Oct 09 '18 18:10 dkent600