arc
arc copied to clipboard
a few miscellaneous items on ExternalLocking4Reputation and Auction4Reputation
- This in
ExternalLocking4Reputation.initializeis redundant with what already exists inLocking4Reputation._initialize:
require(_lockingEndTime > _lockingStartTime,"_lockingEndTime should be greater than _lockingStartTime");
- consider indexing the following event arguments:
FixedReputationAllocation.BeneficiaryAddressAdded._beneficiaryAuction4Reputation.Bid._bidder
FixedReputationAllocation.enabledwill crash whennumberOfBeneficiariesis zero:
beneficiaryReward = uint256(int216(reputationReward).div(int256(numberOfBeneficiaries)).fromReal());
Should we do a require with a message?
@orenyodfat