daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11231 dtx: handle dependency during task conversion

Open Nasf-Fan opened this issue 3 years ago • 5 comments

For the task that need to be handled via distributed transaction, the client side IO logic will convert it to a transactional task. During dc_tx_convert(), the original task maybe freed because of the dependency on the sub-task(s) for existence check inside the dc_tx_attach(). That will cause the "task" to become invalid for subsequent process for the conversion.

To avoid above bad case, the patch moves the TX commit logic for task conversion into related existence check callback before the TX release.

Signed-off-by: Fan Yong [email protected]

Nasf-Fan avatar Aug 09 '22 15:08 Nasf-Fan

Bug-tracker data: Ticket title is 'soak: 2.2 mdtest job fails with "Attempting to use OP ID that was not completed"' Status is 'In Review' Labels: 'triaged' Job should run at elevated priority (2) https://daosio.atlassian.net/browse/DAOS-11231

github-actions[bot] avatar Aug 09 '22 15:08 github-actions[bot]

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9948/3/execution/node/966/log

daosbuild1 avatar Aug 10 '22 12:08 daosbuild1

Test stage Functional Hardware Small completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9948/3/execution/node/966/log

20:35:29 Failed to bring up interface ib1 on wolf-135.wolf.hpdd.intel.com. Please file a CORCI ticket.

To be retested.

Nasf-Fan avatar Aug 10 '22 13:08 Nasf-Fan

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9948/4/display/redirect

daosbuild1 avatar Aug 10 '22 22:08 daosbuild1

@liuxuezhao @liw , would you please to help review the patch again? Thanks!

Nasf-Fan avatar Aug 15 '22 13:08 Nasf-Fan

Please inspect.

johannlombardi avatar Aug 17 '22 17:08 johannlombardi

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9948/9/execution/node/1037/log

daosbuild1 avatar Aug 18 '22 08:08 daosbuild1

Please inspect.

johannlombardi avatar Aug 20 '22 08:08 johannlombardi

Refresh the patch with more restriction for tse_task_complete() and dc_task_decref().

Nasf-Fan avatar Aug 21 '22 03:08 Nasf-Fan