daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11187 dtx: properly handle DTX commit failure

Open Nasf-Fan opened this issue 3 years ago • 8 comments

master-commit: c694916572ddbbea3f9745431bfbe3e317ba3029

When close the container, the DTX logic will try to flush committable ones. Such DTX commit may hit failures. If we hide related failures inside dtx_commit, it will misguide the dtx_flush_on_close() logic as to the DTX flush may be assert for related undeletable DTX entries.

Signed-off-by: Fan Yong [email protected]

Nasf-Fan avatar Aug 05 '22 23:08 Nasf-Fan

Bug-tracker data: Ticket title is 'daos_racer/multi.py:DaosRacerTest.test_daos_racer - ERROR: dmg: pool destroy failed: server: code = 611 description = "DAOS I/O Engine instance not started or not responding on dRPC"' Status is 'Awaiting backport' Labels: 'ci_impact,triaged,weekly_test' Job should run at elevated priority (1) https://daosio.atlassian.net/browse/DAOS-11187

github-actions[bot] avatar Aug 05 '22 23:08 github-actions[bot]

still hasn't gone through merge approval yet

jolivier23 avatar Aug 08 '22 18:08 jolivier23

still hasn't gone through merge approval yet

Do we want to back-port this patch? I think release/2.2 need this patch.

Nasf-Fan avatar Aug 12 '22 05:08 Nasf-Fan

still hasn't gone through merge approval yet

It is marked as "Approved to Merge 2.2 Community Release" in the ticket DAOS-11187, then what are we waiting for? @daos-stack/daos-gatekeeper

Nasf-Fan avatar Aug 26 '22 02:08 Nasf-Fan

It seems that we will not land this patch to release/2.2 at the moment, close it.

Nasf-Fan avatar Sep 12 '22 03:09 Nasf-Fan

Reopen the PR since related issue has been reproduced on release/2.2

Nasf-Fan avatar Oct 11 '22 16:10 Nasf-Fan

Test stage Build on Leap 15 with Intel-C and TARGET_PREFIX completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9914/1/execution/node/585/log

daosbuild1 avatar Oct 11 '22 16:10 daosbuild1

Rebased for the fixes from 02418f398e55e36792ae10616ece7baaf09e2cb8 (PR#10400)

Nasf-Fan avatar Oct 12 '22 01:10 Nasf-Fan

Ping @daos-stack/daos-gatekeeper , would you please to consider to landed to 2.2.1? Thanks! @jolivier23

Nasf-Fan avatar Oct 26 '22 03:10 Nasf-Fan