daos icon indicating copy to clipboard operation
daos copied to clipboard

DAOS-11266 test: Extend ExecutableCommand for DdbCommandBase

Open shimizukko opened this issue 3 years ago • 1 comments

ddb needs to run on a server host, but current implementation of ExecutableCommand runs the command on the test host, so override run() and use run_pcmd() so that we can pass in the target host (server host) as parameter.

Add server_host parameter to DdbCommand and DdbCommandBase class.

Update comments in Returns field in DdbCommand as it returns a list now.

Skip-unit-tests: true Skip-fault-injection-test: true Test-tag: pr

Signed-off-by: Makito Kano [email protected]

shimizukko avatar Aug 05 '22 13:08 shimizukko

Bug-tracker data: Ticket title is 'Implement TargetedExecutableCommand to run ddb on server host' Status is 'In Review' https://daosio.atlassian.net/browse/DAOS-11266

github-actions[bot] avatar Aug 05 '22 13:08 github-actions[bot]

Test stage checkpatch completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9906/5/execution/node/119/log

daosbuild1 avatar Aug 16 '22 17:08 daosbuild1

Test stage Functional Hardware Large completed with status FAILURE. https://build.hpdd.intel.com//job/daos-stack/job/daos/view/change-requests/job/PR-9906/6/execution/node/737/log

daosbuild1 avatar Aug 16 '22 20:08 daosbuild1

@shimizukko what tests in the feature/cat_recovery branch use the DdbCommand class? Do any of them run in the HW Large stage?

phender avatar Aug 17 '22 21:08 phender

@phender The test is not merged yet. It'll use the VM cluster.

shimizukko avatar Aug 18 '22 11:08 shimizukko

@phender The test is not merged yet. It'll use the VM cluster.

So then this PR is not testing the code changes? There are no available tests to execute the code?

The https://build.hpdd.intel.com/job/daos-stack/job/daos/job/PR-9906/6/ build failed to run the HW Large stage due to Failed to bring up interface ib1 on wolf-145.wolf.hpdd.intel.com. which means no HW Large tests were run. I'm just confirming that it would safe to land the changes as there are no HW Large tests that would have been used to verify the modified files.

phender avatar Aug 18 '22 18:08 phender

@phender I didn't realize that the HW Large stage didn't run. I'll restart the stage. Thanks.

shimizukko avatar Aug 18 '22 19:08 shimizukko

@phender HW Large stage passed.

shimizukko avatar Aug 19 '22 10:08 shimizukko